Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2622463002: X87: Revert of [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (… (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
epertoso, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Revert of [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (patchset #3 id:40001 of https://codereview.chromium.org/2605863002/ ). port c16ca32e5fcacd8e3e08e25a1dd7053015fb43ee (r42092) original commit message: Reason for revert: Breaks wasm benchmark (http://crbug.com/v8/5798). Original issue's description: > [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms > > Recognize and emit in-memory comparisons of 8-bit and 16-bit values with > immediate values that fit. > > LOG=N > R=epertoso@chromium.org > > Review-Url: https://codereview.chromium.org/2605863002 > Cr-Commit-Position: refs/heads/master@{#41971} > Committed: https://chromium.googlesource.com/v8/v8/+/be11812c53ff6c8ce320887bc76a3b60d8103695 BUG= Review-Url: https://codereview.chromium.org/2622463002 Cr-Commit-Position: refs/heads/master@{#42126} Committed: https://chromium.googlesource.com/v8/v8/+/8b900b8ba968594301e81ffe55d671acb5dc0c4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -44 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +13 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-09 03:13:34 UTC) #2
chunyang.dai
On 2017/01/09 03:13:34, zhengxing.li wrote: > PTAL, thanks! LGTM. thanks
3 years, 11 months ago (2017-01-09 08:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622463002/1
3 years, 11 months ago (2017-01-09 08:40:57 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 09:06:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8b900b8ba968594301e81ffe55d671acb5d...

Powered by Google App Engine
This is Rietveld 408576698