third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp - Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber (Closed)

Patch Set: remove template, rely on function overload resolution for Vector-specific methods Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

index 8de896ce6e92e13e6ad02758a6ef3886c4e5a1a6..137e1847aff52a24a1f66b83a0d73877c09073cc 100644

--- a/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

+++ b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

@@ -326,7 +326,7 @@ String stringForSkColor(const SkColor& color) {

// #AARRGGBB.

Vector<LChar, 9> result;

result.push_back('#');

- appendUnsignedAsHex(color, result);

+ HexNumber::appendUnsignedAsHex(color, result);

return String(result.data(), result.size());

}