third_party/WebKit/Source/platform/network/FormDataEncoder.cpp - Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber (Closed)

Patch Set: remove template, rely on function overload resolution for Vector-specific methods Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

diff --git a/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp b/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

index d45201e2efdedb19224d4e5e4f07bd505d526851..47cb5314c0c7dd9593c8887d4e6d542e0a58568e 100644

--- a/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

+++ b/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

@@ -48,7 +48,7 @@ static inline void append(Vector<char>& buffer, const CString& string) {

static inline void appendPercentEncoded(Vector<char>& buffer, unsigned char c) {

append(buffer, '%');

- appendByteAsHex(c, buffer);

+ HexNumber::appendByteAsHex(c, buffer);

}

static void appendQuotedString(Vector<char>& buffer, const CString& string) {