third_party/WebKit/Source/platform/graphics/Color.cpp - Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Color.cpp

Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber (Closed)

Patch Set: remove template, rely on function overload resolution for Vector-specific methods Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/Color.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/Color.cpp b/third_party/WebKit/Source/platform/graphics/Color.cpp

index 3b406bf1a1addf7976e8fa71e0d6b7eb4ab519bc..c82a1e0ba9ea2a849adeddba35640a10ace7d52b 100644

--- a/third_party/WebKit/Source/platform/graphics/Color.cpp

+++ b/third_party/WebKit/Source/platform/graphics/Color.cpp

@@ -231,9 +231,9 @@ String Color::serialized() const {

StringBuilder builder;

builder.reserveCapacity(7);

builder.append('#');

- appendByteAsHex(red(), builder, Lowercase);

- appendByteAsHex(green(), builder, Lowercase);

- appendByteAsHex(blue(), builder, Lowercase);

+ HexNumber::appendByteAsHex(red(), builder, HexNumber::Lowercase);

+ HexNumber::appendByteAsHex(green(), builder, HexNumber::Lowercase);

+ HexNumber::appendByteAsHex(blue(), builder, HexNumber::Lowercase);

return builder.toString();

}