third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp - Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

Issue 2622363005: Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber (Closed)

Patch Set: remove template, rely on function overload resolution for Vector-specific methods Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

index 3e284b403c61958a9ae7271c0743b0d88be16aef..47c782e472b119e9f3c3c46628d308bb47e80dec 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

@@ -366,8 +366,9 @@ String BluetoothUUID::getDescriptor(StringOrUnsignedLong name,

String BluetoothUUID::canonicalUUID(unsigned alias) {

StringBuilder builder;

builder.reserveCapacity(36 /* 36 chars or 128 bits, length of a UUID */);

- appendUnsignedAsHexFixedSize(

- alias, builder, 8 /* 8 chars or 32 bits, prefix length */, Lowercase);

+ HexNumber::appendUnsignedAsHexFixedSize(

+ alias, builder, 8 /* 8 chars or 32 bits, prefix length */,

+ HexNumber::Lowercase);

builder.append("-0000-1000-8000-00805f9b34fb");

return builder.toString();