Issue 2622143002: MD system tray: Avoid adding separator as the first item of Bluetooth device list.

Issue 2622143002: MD system tray: Avoid adding separator as the first item of Bluetooth device list. (Closed)

Created:
3 years, 11 months ago by fukino

Modified:
3 years, 11 months ago

Reviewers:
jennyz

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

MD system tray: Avoid adding separator as the first item of Bluetooth device list. In pre-MD device list, TrayDetailsView::AddScrollSeparator() checked if the added separator was the first item or not. https://codesearch.chromium.org/chromium/src/ash/common/system/tray/tray_details_view.cc?q=TrayDetailsView::AddScrollSeparator&sq=package:chromium&l=430&dr=CSs We should do the same check in MD version of Bluetooth device list, too. BUG=675566 TBR=jennyz@chromium.org Review-Url: https://codereview.chromium.org/2582293003 Cr-Commit-Position: refs/heads/master@{#442473} (cherry picked from commit b613df596c63e3e69b4addaaa676e54877b8f261) Review-Url: https://codereview.chromium.org/2622143002 . Cr-Commit-Position: refs/branch-heads/2924@{#727} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/5076457588c1ed7f300b8583f0cbfe61bb173725

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	ash/common/system/chromeos/bluetooth/tray_bluetooth.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

fukino

3 years, 11 months ago (2017-01-11 05:01:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5076457588c1ed7f300b8583f0cbfe61bb173725.