Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2582293003: MD system tray: Avoid adding separator as the first item of Bluetooth device list. (Closed)

Created:
4 years ago by fukino
Modified:
3 years, 11 months ago
Reviewers:
jennyz
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD system tray: Avoid adding separator as the first item of Bluetooth device list. In pre-MD device list, TrayDetailsView::AddScrollSeparator() checked if the added separator was the first item or not. https://codesearch.chromium.org/chromium/src/ash/common/system/tray/tray_details_view.cc?q=TrayDetailsView::AddScrollSeparator&sq=package:chromium&l=430&dr=CSs We should do the same check in MD version of Bluetooth device list, too. BUG=675566 Review-Url: https://codereview.chromium.org/2582293003 Cr-Commit-Position: refs/heads/master@{#442473} Committed: https://chromium.googlesource.com/chromium/src/+/b613df596c63e3e69b4addaaa676e54877b8f261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
fukino
Hi Jenny, could you take a look?
4 years ago (2016-12-19 11:04:26 UTC) #2
fukino
Friendly ping.
4 years ago (2016-12-22 05:35:38 UTC) #3
jennyz
lgtm
3 years, 11 months ago (2017-01-06 21:43:12 UTC) #4
tdanderson
On 2017/01/06 21:43:12, jennyz wrote: > lgtm fukino@, friendly ping - is this ready to ...
3 years, 11 months ago (2017-01-09 20:39:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582293003/1
3 years, 11 months ago (2017-01-10 01:09:42 UTC) #7
fukino
On 2017/01/09 20:39:10, tdanderson wrote: > On 2017/01/06 21:43:12, jennyz wrote: > > lgtm > ...
3 years, 11 months ago (2017-01-10 01:10:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 11 months ago (2017-01-10 03:11:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582293003/1
3 years, 11 months ago (2017-01-10 03:56:20 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 04:41:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b613df596c63e3e69b4addaaa676...

Powered by Google App Engine
This is Rietveld 408576698