Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2622023002: Revert of [wasm][asm.js] Enable --validate-asm by default. (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm][asm.js] Enable --validate-asm by default. (patchset #1 id:1 of https://codereview.chromium.org/2624813002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/12554 See also: https://github.com/v8/v8/wiki/Blink%20layout%20tests Original issue's description: > [wasm][asm.js] Enable --validate-asm by default. > > This directs all asm.js traffic via the Wasm backend. > > R=titzer@chromium.org,aseemgarg@chromium.org > BUG=v8:4203 > > Review-Url: https://codereview.chromium.org/2624813002 > Cr-Commit-Position: refs/heads/master@{#42194} > Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652562ad TBR=aseemgarg@chromium.org,titzer@chromium.org,bradnelson@google.com,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2622023002 Cr-Commit-Position: refs/heads/master@{#42200} Committed: https://chromium.googlesource.com/v8/v8/+/0e03bea7eacdd933b5b80556ca70c7bf7261b4db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [wasm][asm.js] Enable --validate-asm by default.
3 years, 11 months ago (2017-01-10 21:08:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622023002/1
3 years, 11 months ago (2017-01-10 21:09:03 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 21:09:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0e03bea7eacdd933b5b80556ca70c7bf726...

Powered by Google App Engine
This is Rietveld 408576698