Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: net/http/http_stream_factory_impl_request_unittest.cc

Issue 2621983004: Improve HttpStreamFactory NetLog events (Closed)
Patch Set: Get rid of long-running Source Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_request_unittest.cc
diff --git a/net/http/http_stream_factory_impl_request_unittest.cc b/net/http/http_stream_factory_impl_request_unittest.cc
index f8b1c393314d5cc58d3175f3367deff95a1ddc99..d0f863da68a0225858e73c7135773cd5248ef358 100644
--- a/net/http/http_stream_factory_impl_request_unittest.cc
+++ b/net/http/http_stream_factory_impl_request_unittest.cc
@@ -12,6 +12,7 @@
#include "net/http/http_stream_factory_impl_job.h"
#include "net/http/http_stream_factory_impl_job_controller.h"
#include "net/http/http_stream_factory_test_util.h"
+#include "net/log/net_log_with_source.h"
#include "net/proxy/proxy_info.h"
#include "net/proxy/proxy_service.h"
#include "net/spdy/spdy_test_util_common.h"
@@ -32,16 +33,17 @@ TEST_F(HttpStreamFactoryImplRequestTest, SetPriority) {
static_cast<HttpStreamFactoryImpl*>(session->http_stream_factory());
MockHttpStreamRequestDelegate request_delegate;
TestJobFactory job_factory;
+ NetLogWithSource net_log;
HttpStreamFactoryImpl::JobController* job_controller =
- new HttpStreamFactoryImpl::JobController(factory, &request_delegate,
- session.get(), &job_factory);
+ new HttpStreamFactoryImpl::JobController(
+ factory, &request_delegate, session.get(), &job_factory,
+ /*is_preconnect=*/false, net_log);
factory->job_controller_set_.insert(base::WrapUnique(job_controller));
HttpRequestInfo request_info;
- std::unique_ptr<HttpStreamFactoryImpl::Request> request(
- job_controller->Start(request_info, &request_delegate, nullptr,
- NetLogWithSource(), HttpStreamRequest::HTTP_STREAM,
- DEFAULT_PRIORITY, SSLConfig(), SSLConfig()));
+ std::unique_ptr<HttpStreamFactoryImpl::Request> request(job_controller->Start(
+ request_info, &request_delegate, nullptr, HttpStreamRequest::HTTP_STREAM,
+ DEFAULT_PRIORITY, SSLConfig(), SSLConfig()));
EXPECT_TRUE(job_controller->main_job());
EXPECT_EQ(DEFAULT_PRIORITY, job_controller->main_job()->priority());

Powered by Google App Engine
This is Rietveld 408576698