Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: net/http/http_stream_factory_impl_request.h

Issue 2621983004: Improve HttpStreamFactory NetLog events (Closed)
Patch Set: Get rid of long-running Source Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_request.h
diff --git a/net/http/http_stream_factory_impl_request.h b/net/http/http_stream_factory_impl_request.h
index 91cb0d7a0c1bbcb03c7e61882cdcc47278e4d7a5..332f5da6ce1b65b0fc9bf830fffde313df508b28 100644
--- a/net/http/http_stream_factory_impl_request.h
+++ b/net/http/http_stream_factory_impl_request.h
@@ -50,7 +50,7 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest {
HttpStreamRequest::Delegate* delegate,
WebSocketHandshakeStreamBase::CreateHelper*
websocket_handshake_stream_create_helper,
- const NetLogWithSource& net_log,
+ const NetLogWithSource* net_log,
StreamType stream_type);
~Request() override;
@@ -58,8 +58,6 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest {
// The GURL from the HttpRequestInfo the started the Request.
const GURL& url() const { return url_; }
- const NetLogWithSource& net_log() const { return net_log_; }
-
// Called when the |helper_| determines the appropriate |spdy_session_key|
// for the Request. Note that this does not mean that SPDY is necessarily
// supported for this SpdySessionKey, since we may need to wait for NPN to
@@ -135,7 +133,10 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest {
WebSocketHandshakeStreamBase::CreateHelper* const
websocket_handshake_stream_create_helper_;
HttpStreamRequest::Delegate* const delegate_;
- const NetLogWithSource net_log_;
+
+ // Initialized to point to the NetLogWithSource of JobController. Valid for
+ // the lifetime of |this|.
+ const NetLogWithSource* net_log_;
eroman 2017/01/25 19:55:27 NetLogWithSource supports copy-construction do thi
xunjieli 2017/01/25 21:41:49 Done.
std::unique_ptr<const SpdySessionKey> spdy_session_key_;

Powered by Google App Engine
This is Rietveld 408576698