Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: net/http/http_stream_factory_impl_request.cc

Issue 2621983004: Improve HttpStreamFactory NetLog events (Closed)
Patch Set: Get rid of long-running Source Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_request.cc
diff --git a/net/http/http_stream_factory_impl_request.cc b/net/http/http_stream_factory_impl_request.cc
index e6bcbe42c68a3fabb2259f8332fa58b1537a3970..57346a67e9b21d5faa3ede59cbb2b15b3956d25b 100644
--- a/net/http/http_stream_factory_impl_request.cc
+++ b/net/http/http_stream_factory_impl_request.cc
@@ -21,7 +21,7 @@ HttpStreamFactoryImpl::Request::Request(
HttpStreamRequest::Delegate* delegate,
WebSocketHandshakeStreamBase::CreateHelper*
websocket_handshake_stream_create_helper,
- const NetLogWithSource& net_log,
+ const NetLogWithSource* net_log,
StreamType stream_type)
: url_(url),
helper_(helper),
@@ -35,12 +35,13 @@ HttpStreamFactoryImpl::Request::Request(
using_spdy_(false),
stream_type_(stream_type) {
DCHECK(delegate_);
+ DCHECK(net_log_);
- net_log_.BeginEvent(NetLogEventType::HTTP_STREAM_REQUEST);
+ net_log_->BeginEvent(NetLogEventType::HTTP_STREAM_REQUEST);
}
HttpStreamFactoryImpl::Request::~Request() {
- net_log_.EndEvent(NetLogEventType::HTTP_STREAM_REQUEST);
+ net_log_->EndEvent(NetLogEventType::HTTP_STREAM_REQUEST);
helper_->OnRequestComplete();
}

Powered by Google App Engine
This is Rietveld 408576698