Improve HttpStreamFactory NetLog events

net/http/http_stream_factory_impl_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_REQUEST_H_
 #define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_REQUEST_H_
 
 #include <memory>
 #include <set>
 
@@ skipping 32 matching lines @@
     virtual void SetPriority(RequestPriority priority) = 0;
   };
 
   // Request will notify |job_controller| when it's destructed.
   // Thus |job_controller| is valid for the lifetime of the |this| Request.
   Request(const GURL& url,
           Helper* helper,
           HttpStreamRequest::Delegate* delegate,
           WebSocketHandshakeStreamBase::CreateHelper*
               websocket_handshake_stream_create_helper,
-          const NetLogWithSource& net_log,
+          const NetLogWithSource* net_log,
           StreamType stream_type);
 
   ~Request() override;
 
   // The GURL from the HttpRequestInfo the started the Request.
   const GURL& url() const { return url_; }
 
-  const NetLogWithSource& net_log() const { return net_log_; }
-
   // Called when the |helper_| determines the appropriate |spdy_session_key|
   // for the Request. Note that this does not mean that SPDY is necessarily
   // supported for this SpdySessionKey, since we may need to wait for NPN to
   // complete before knowing if SPDY is available.
   void SetSpdySessionKey(const SpdySessionKey& spdy_session_key);
   bool HasSpdySessionKey() const;
 
   // Marks completion of the request. Must be called before OnStreamReady().
   void Complete(bool was_alpn_negotiated,
                 NextProto negotiated_protocol,
@@ skipping 55 matching lines @@
 
  private:
   const GURL url_;
 
   // Unowned. The helper must outlive this request.
   Helper* helper_;
 
   WebSocketHandshakeStreamBase::CreateHelper* const
       websocket_handshake_stream_create_helper_;
   HttpStreamRequest::Delegate* const delegate_;
-  const NetLogWithSource net_log_;
+
+  // Initialized to point to the NetLogWithSource of JobController. Valid for
+  // the lifetime of |this|.
+  const NetLogWithSource* net_log_;

[eroman, 2017/01/25 19:55:27]

NetLogWithSource supports copy-construction do this doesn't need to be a pointer
(can have a copy of NetLogWithSource instead -- all it is is a pointer to NetLog
and a Source identifier).

[xunjieli, 2017/01/25 21:41:49]

Done.

 
   std::unique_ptr<const SpdySessionKey> spdy_session_key_;
 
   bool completed_;
   bool was_alpn_negotiated_;
   // Protocol negotiated with the server.
   NextProto negotiated_protocol_;
   bool using_spdy_;
   ConnectionAttempts connection_attempts_;
 
   const HttpStreamRequest::StreamType stream_type_;
   DISALLOW_COPY_AND_ASSIGN(Request);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_REQUEST_H_