[heap, debugger] Introduce out-of-memory listener for debugger.

[heap, debugger] Introduce out-of-memory listener for debugger.

This API will allow DevTools to intercept out-of-memory condition,
increase the heap limit and schedule heap snapshot.

BUG=chromium:675911
Review-Url: https://codereview.chromium.org/2621873003
Cr-Commit-Position: refs/heads/master@{#42225}
Committed: https://chromium.googlesource.com/v8/v8/+/0959983c1afadeedfd9dad432a1eeccbde26dec3

[kozy, 2017-01-10 17:18:41]

kozyatinskiy@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[kozy, 2017-01-10 17:18:42]

I'm not an owner of anything from changed files but from point of view of using
this API on inspector side - lgtm.

https://codereview.chromium.org/2621873003/diff/80001/src/debug/debug-interfa...
File src/debug/debug-interface.h (right):

https://codereview.chromium.org/2621873003/diff/80001/src/debug/debug-interfa...
src/debug/debug-interface.h:148: typedef void (*OutOfMemoryCallback)(Isolate*
isolate, void* data);
We don't really need isolate here since we'll pass V8Debugger* as data argument
and V8Debugger contains pointer to isolate.

[ulan, 2017-01-10 17:22:00]

https://codereview.chromium.org/2621873003/diff/80001/src/debug/debug-interfa...
File src/debug/debug-interface.h (right):

https://codereview.chromium.org/2621873003/diff/80001/src/debug/debug-interfa...
src/debug/debug-interface.h:148: typedef void (*OutOfMemoryCallback)(Isolate*
isolate, void* data);
On 2017/01/10 17:18:41, kozyatinskiy wrote:
> We don't really need isolate here since we'll pass V8Debugger* as data
argument
> and V8Debugger contains pointer to isolate.

Done.

[ulan, 2017-01-10 17:22:27]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org, yangguo@chromium.org

[ulan, 2017-01-10 17:22:28]

ptal

[ulan, 2017-01-11 09:43:14]

Yang, do src/debug changes look good?

[Yang, 2017-01-11 09:59:47]

On 2017/01/11 09:43:14, ulan wrote:
> Yang, do src/debug changes look good?

LGTM.

However, include/v8.h already has an OOMErrorCallback called on
FatalProcessOutOfMemory. I wonder whether we should come up with a more
desciptive name for  Heap::SetOutOfMemoryCallback here.

[Hannes Payer (out of office), 2017-01-11 12:40:01]

lgtm

[ulan, 2017-01-11 12:52:19]

On 2017/01/11 09:59:47, Yang wrote:
> On 2017/01/11 09:43:14, ulan wrote:
> > Yang, do src/debug changes look good?
> 
> LGTM.
> 
> However, include/v8.h already has an OOMErrorCallback called on
> FatalProcessOutOfMemory. I wonder whether we should come up with a more
> desciptive name for  Heap::SetOutOfMemoryCallback here.

I'd like to keep the current name since it will be used only by the inspector.
The old callback has "Error" in the name, which gives some disambiguation.

[ulan, 2017-01-11 12:52:25]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-01-11 12:52:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2621873003/#ps100001
(title: "remove isolate parameter of the callback")

[commit-bot: I haz the power, 2017-01-11 12:52:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 13:20:53]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484139145169150,
"parent_rev": "fc241b907732a5547d6302e367a7ec0da9e24909", "commit_rev":
"0959983c1afadeedfd9dad432a1eeccbde26dec3"}

[commit-bot: I haz the power, 2017-01-11 13:20:59]

Description was changed from

==========
[heap, debugger] Introduce out-of-memory listener for debugger.

This API will allow DevTools to intercept out-of-memory condition,
increase the heap limit and schedule heap snapshot.

BUG=chromium:675911
==========

to

==========
[heap, debugger] Introduce out-of-memory listener for debugger.

This API will allow DevTools to intercept out-of-memory condition,
increase the heap limit and schedule heap snapshot.

BUG=chromium:675911

Review-Url: https://codereview.chromium.org/2621873003
Cr-Commit-Position: refs/heads/master@{#42225}
Committed:
https://chromium.googlesource.com/v8/v8/+/0959983c1afadeedfd9dad432a1eeccbde2...
==========

[commit-bot: I haz the power, 2017-01-11 13:21:00]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/0959983c1afadeedfd9dad432a1eeccbde2...