[inspector] unconditionally pause on OOM

[inspector] unconditionally pause on OOM

Currently V8 context just crashes on OOM, with this CL backend will send paused notification with OOM reason before OOM and will increase heap limits to allow further debugging on pause.

BUG=chromium:675911
Review-Url: https://codereview.chromium.org/2624543004
Cr-Commit-Position: refs/heads/master@{#42480}
Committed: https://chromium.googlesource.com/v8/v8/+/9662547c15db6dc54169a3d2da91048d3d669fda

[kozy, 2017-01-11 10:18:01]

Patchset #2 (id:20001) has been deleted

[kozy, 2017-01-11 10:20:54]

Description was changed from

==========
[inspector] break on OOM

BUG=chromium:675911
==========

to

==========
[inspector] unconditionally break on OOM

Currently V8 context just crashes on OOM, with this CL backend will send paused
notification with OOM reason before OOM and will increase heap limits to allow
further debugging.

BUG=chromium:675911
==========

[kozy, 2017-01-11 10:20:54]

kozyatinskiy@chromium.org changed reviewers:
+ dgozman@chromium.org, ulan@chromium.org

[kozy, 2017-01-11 10:21:08]

Description was changed from

==========
[inspector] unconditionally break on OOM

Currently V8 context just crashes on OOM, with this CL backend will send paused
notification with OOM reason before OOM and will increase heap limits to allow
further debugging.

BUG=chromium:675911
==========

to

==========
[inspector] unconditionally pause on OOM

Currently V8 context just crashes on OOM, with this CL backend will send paused
notification with OOM reason before OOM and will increase heap limits to allow
further debugging.

BUG=chromium:675911
==========

[kozy, 2017-01-11 10:21:28]

Dmitry and Ulan, please take a look.

[ulan, 2017-01-11 19:42:09]

The usage of v8 api lgtm.

[kozy, 2017-01-17 20:17:42]

Description was changed from

==========
[inspector] unconditionally pause on OOM

Currently V8 context just crashes on OOM, with this CL backend will send paused
notification with OOM reason before OOM and will increase heap limits to allow
further debugging.

BUG=chromium:675911
==========

to

==========
[inspector] unconditionally pause on OOM

Currently V8 context just crashes on OOM, with this CL backend will send paused
notification with OOM reason before OOM and will increase heap limits to allow
further debugging on pause.

BUG=chromium:675911
==========

[kozy, 2017-01-17 20:18:18]

kozyatinskiy@chromium.org changed reviewers:
+ aplh@chromium.org

[kozy, 2017-01-17 20:20:28]

kozyatinskiy@chromium.org changed reviewers:
+ alph@chromium.org
- aplh@chromium.org

[kozy, 2017-01-17 20:20:28]

Alexei, please take a look!

[kozy, 2017-01-17 20:20:39]

Patchset #2 (id:40001) has been deleted

[kozy, 2017-01-17 20:20:49]

Patchset #2 (id:60001) has been deleted

[dgozman, 2017-01-18 16:47:56]

lgtm

https://codereview.chromium.org/2624543004/diff/80001/test/inspector/debugger...
File test/inspector/debugger/pause-on-oom.js (right):

https://codereview.chromium.org/2624543004/diff/80001/test/inspector/debugger...
test/inspector/debugger/pause-on-oom.js:1: // Copyright 2016 the V8 project
authors. All rights reserved.
2017

[kozy, 2017-01-18 16:55:33]

thanks!
all done.

https://codereview.chromium.org/2624543004/diff/80001/test/inspector/debugger...
File test/inspector/debugger/pause-on-oom.js (right):

https://codereview.chromium.org/2624543004/diff/80001/test/inspector/debugger...
test/inspector/debugger/pause-on-oom.js:1: // Copyright 2016 the V8 project
authors. All rights reserved.
On 2017/01/18 16:47:55, dgozman wrote:
> 2017

Done.

[kozy, 2017-01-18 16:55:48]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-01-18 16:55:48]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2624543004/#ps100001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-01-18 16:55:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 17:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 17:33:14]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[kozy, 2017-01-18 19:36:13]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-01-18 19:36:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2624543004/#ps120001
(title: "much better test")

[commit-bot: I haz the power, 2017-01-18 19:36:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 19:56:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:56:27]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21177)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[kozy, 2017-01-18 20:14:12]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-01-18 20:14:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2624543004/#ps140001
(title: "better test")

[commit-bot: I haz the power, 2017-01-18 20:14:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 20:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 20:18:36]

Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[kozy, 2017-01-18 20:23:41]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-01-18 20:23:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2624543004/#ps160001
(title: "rebased")

[commit-bot: I haz the power, 2017-01-18 20:23:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 20:46:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 20:46:12]

Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19477)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[kozy, 2017-01-18 21:16:30]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:16:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:35:10]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484774190231640,
"parent_rev": "51a4b9f914fad6f0f0ea0dc2e43e648e132f6653", "commit_rev":
"9662547c15db6dc54169a3d2da91048d3d669fda"}

[commit-bot: I haz the power, 2017-01-18 21:35:15]

Description was changed from

==========
[inspector] unconditionally pause on OOM

Currently V8 context just crashes on OOM, with this CL backend will send paused
notification with OOM reason before OOM and will increase heap limits to allow
further debugging on pause.

BUG=chromium:675911
==========

to

==========
[inspector] unconditionally pause on OOM

Currently V8 context just crashes on OOM, with this CL backend will send paused
notification with OOM reason before OOM and will increase heap limits to allow
further debugging on pause.

BUG=chromium:675911

Review-Url: https://codereview.chromium.org/2624543004
Cr-Commit-Position: refs/heads/master@{#42480}
Committed:
https://chromium.googlesource.com/v8/v8/+/9662547c15db6dc54169a3d2da91048d3d6...
==========

[commit-bot: I haz the power, 2017-01-18 21:35:17]

Committed patchset #6 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/9662547c15db6dc54169a3d2da91048d3d6...