Remove --enable-apps-file-associations flag.

Remove --enable-apps-file-associations flag.

The flag was for an old feature that was never launched. Removes the
code behind this feature.

BUG=540055
Review-Url: https://codereview.chromium.org/2621833003
Cr-Commit-Position: refs/heads/master@{#442763}
Committed: https://chromium.googlesource.com/chromium/src/+/f3cf6cd4d7eac508f40f1650cbb8dbeac4f13ebb

[Matt Giuca, 2017-01-10 02:19:25]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 02:20:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:27:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 04:27:49]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Matt Giuca, 2017-01-10 04:41:41]

mgiuca@chromium.org changed reviewers:
+ benwells@chromium.org

[Matt Giuca, 2017-01-10 04:41:42]

Hi Ben (and Trent if desired since you may have opinions about this).

Is there any other dead code for this that you know of? It seems fairly
self-contained within the removed function UpdateFileTypes, but that seems quite
small for this feature. (This doesn't necessitate removal of the whole shim
feature, I gather...)

[benwells, 2017-01-10 22:26:37]

lgtm, that's it afaik

[tapted, 2017-01-10 22:59:51]

tapted@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2017-01-10 22:59:52]

oops - i forgot to press publish... (blames jetlag..)

https://codereview.chromium.org/2621833003/diff/1/chrome/browser/web_applicat...
File chrome/browser/web_applications/web_app_mac.mm (left):

https://codereview.chromium.org/2621833003/diff/1/chrome/browser/web_applicat...
chrome/browser/web_applications/web_app_mac.mm:532: const
extensions::FileHandlersInfo& file_handlers_info) {
Can this entire type `FileHandlersInfo` be deleted? (Or, at least, the argument
removed from CreatePlatformShortcuts(), and data member removed from
WebAppShortcutCreator?)

I poked around at how it's used - it seems essentially unused everywhere I
checked. E.g. web_app_linux.cc has it as an argument for a couple of functions,
but never uses the arg. same with web_app_win.cc. web_app.cc has
IgnoreFileHandlersInfo(..) to ignore the arg, and GetInfoForApp() reads it and
passes it through a chain of callbacks that seems to end up at a post task to
web_app::internals::CreatePlatformShortcuts(..)  -- it looks like web_app_mac's
web_app::WebAppShortcutCreator(..) was the last thing using it, and after the
WebAppShortcutCreator::UpdatePlist(..) change below WebAppShortcutCreator no
longer needs the |file_handlers_info_| data member.

[benwells, 2017-01-10 23:20:15]

On 2017/01/10 22:59:52, tapted wrote:
> oops - i forgot to press publish... (blames jetlag..)
> 
>
https://codereview.chromium.org/2621833003/diff/1/chrome/browser/web_applicat...
> File chrome/browser/web_applications/web_app_mac.mm (left):
> 
>
https://codereview.chromium.org/2621833003/diff/1/chrome/browser/web_applicat...
> chrome/browser/web_applications/web_app_mac.mm:532: const
> extensions::FileHandlersInfo& file_handlers_info) {
> Can this entire type `FileHandlersInfo` be deleted? (Or, at least, the
argument
> removed from CreatePlatformShortcuts(), and data member removed from
> WebAppShortcutCreator?)
> 
> I poked around at how it's used - it seems essentially unused everywhere I
> checked. E.g. web_app_linux.cc has it as an argument for a couple of
functions,
> but never uses the arg. same with web_app_win.cc. web_app.cc has
> IgnoreFileHandlersInfo(..) to ignore the arg, and GetInfoForApp() reads it and
> passes it through a chain of callbacks that seems to end up at a post task to
> web_app::internals::CreatePlatformShortcuts(..)  -- it looks like
web_app_mac's
> web_app::WebAppShortcutCreator(..) was the last thing using it, and after the
> WebAppShortcutCreator::UpdatePlist(..) change below WebAppShortcutCreator no
> longer needs the |file_handlers_info_| data member.

I think the type is still used on ChromeOS, but the interactions with web_app
can probably all go.

[Matt Giuca, 2017-01-11 00:56:52]

Thanks for spotting that. Ben's assessment is correct; we can't remove it
entirely due to Chrome OS but we can remove it from all over web_app.

Done that in a follow-up CL since it isn't very related to this:
https://codereview.chromium.org/2621163005

[Matt Giuca, 2017-01-11 00:58:20]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2017-01-11 00:58:53]

https://codereview.chromium.org/2621833003/diff/1/chrome/browser/web_applicat...
File chrome/browser/web_applications/web_app_mac.mm (left):

https://codereview.chromium.org/2621833003/diff/1/chrome/browser/web_applicat...
chrome/browser/web_applications/web_app_mac.mm:532: const
extensions::FileHandlersInfo& file_handlers_info) {
On 2017/01/10 22:59:52, tapted wrote:
> Can this entire type `FileHandlersInfo` be deleted? (Or, at least, the
argument
> removed from CreatePlatformShortcuts(), and data member removed from
> WebAppShortcutCreator?)
> 
> I poked around at how it's used - it seems essentially unused everywhere I
> checked. E.g. web_app_linux.cc has it as an argument for a couple of
functions,
> but never uses the arg. same with web_app_win.cc. web_app.cc has
> IgnoreFileHandlersInfo(..) to ignore the arg, and GetInfoForApp() reads it and
> passes it through a chain of callbacks that seems to end up at a post task to
> web_app::internals::CreatePlatformShortcuts(..)  -- it looks like
web_app_mac's
> web_app::WebAppShortcutCreator(..) was the last thing using it, and after the
> WebAppShortcutCreator::UpdatePlist(..) change below WebAppShortcutCreator no
> longer needs the |file_handlers_info_| data member.

Acknowledged: See previous email.

[commit-bot: I haz the power, 2017-01-11 00:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:40:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484096300241180, "parent_rev":
"bff54a249b1e7e9fddc1740d980c0bafacf10970", "commit_rev":
"f3cf6cd4d7eac508f40f1650cbb8dbeac4f13ebb"}

[commit-bot: I haz the power, 2017-01-11 01:40:57]

Description was changed from

==========
Remove --enable-apps-file-associations flag.

The flag was for an old feature that was never launched. Removes the
code behind this feature.

BUG=540055
==========

to

==========
Remove --enable-apps-file-associations flag.

The flag was for an old feature that was never launched. Removes the
code behind this feature.

BUG=540055

Review-Url: https://codereview.chromium.org/2621833003
Cr-Commit-Position: refs/heads/master@{#442763}
Committed:
https://chromium.googlesource.com/chromium/src/+/f3cf6cd4d7eac508f40f1650cbb8...
==========

[commit-bot: I haz the power, 2017-01-11 01:40:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f3cf6cd4d7eac508f40f1650cbb8...