Remove all use of FileHandlersInfo from desktop shortcut creation.

Remove all use of FileHandlersInfo from desktop shortcut creation.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
Review-Url: https://codereview.chromium.org/2621163005
Cr-Commit-Position: refs/heads/master@{#448200}
Committed: https://chromium.googlesource.com/chromium/src/+/918c5da31d9ccd80f22baca6151b19f3b4f17cff

[Matt Giuca, 2017-01-11 00:58:10]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 00:58:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:24:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Matt Giuca, 2017-01-11 01:49:29]

Description was changed from

==========
web_app: Remove all use of FileHandlersInfo from this part of the code.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was recently removed). Removed all the passing of FileHandlersInfo
and cleaned up.

BUG=540055
==========

to

==========
web_app: Remove all use of FileHandlersInfo from this part of the code.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
==========

[Matt Giuca, 2017-01-11 02:08:17]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:08:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 03:02:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 03:02:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Matt Giuca, 2017-02-03 03:49:02]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 03:49:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2017-02-03 04:41:01]

mgiuca@chromium.org changed reviewers:
+ msw@chromium.org, tapted@chromium.org

[Matt Giuca, 2017-02-03 04:41:02]

Some more cleanup from the Old Days.

msw@chromium.org: Please review changes in c/b/ui/views.

tapted@chromium.org: Please review changes in c/b/apps and c/b/web_applications.

Thanks!

[commit-bot: I haz the power, 2017-02-03 04:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 04:45:37]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-02-03 05:12:06]

lgtm

https://codereview.chromium.org/2621163005/diff/30001/chrome/browser/apps/app...
File chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm (right):

https://codereview.chromium.org/2621163005/diff/30001/chrome/browser/apps/app...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:1: // Copyright
2014 The Chromium Authors. All rights reserved.
CL description maybe "this part of the code" -> "desktop shortcut creation"? or
similar

[Matt Giuca, 2017-02-03 05:21:35]

Description was changed from

==========
web_app: Remove all use of FileHandlersInfo from this part of the code.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
==========

to

==========
web_app: Remove use of FileHandlersInfo from desktop shortcut creation.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
==========

[Matt Giuca, 2017-02-03 05:21:56]

Description was changed from

==========
web_app: Remove use of FileHandlersInfo from desktop shortcut creation.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
==========

to

==========
Remove all use of FileHandlersInfo from desktop shortcut creation.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
==========

[Matt Giuca, 2017-02-03 05:22:08]

Description was changed from

==========
Remove all use of FileHandlersInfo from desktop shortcut creation.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
==========

to

==========
Remove all use of FileHandlersInfo from desktop shortcut creation.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
==========

[Matt Giuca, 2017-02-03 05:22:20]

https://codereview.chromium.org/2621163005/diff/30001/chrome/browser/apps/app...
File chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm (right):

https://codereview.chromium.org/2621163005/diff/30001/chrome/browser/apps/app...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2017/02/03 05:12:06, tapted wrote:
> CL description maybe "this part of the code" -> "desktop shortcut creation"?
or
> similar

Done.

[msw, 2017-02-03 08:51:05]

c/b/ui/views lgtm

[Matt Giuca, 2017-02-06 00:27:47]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2017-02-06 00:27:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 01:20:33]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1486340867513290,
"parent_rev": "cd7260e572d5ca42b281f99a1ebdfce9381f82ca", "commit_rev":
"918c5da31d9ccd80f22baca6151b19f3b4f17cff"}

[commit-bot: I haz the power, 2017-02-06 01:21:52]

Description was changed from

==========
Remove all use of FileHandlersInfo from desktop shortcut creation.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055
==========

to

==========
Remove all use of FileHandlersInfo from desktop shortcut creation.

File handler information was being passed all around the web app and
shortcut creation code and not being used (due to an unlaunched feature
that was removed in r442763). Removed all the passing of
FileHandlersInfo and cleaned up.

BUG=540055

Review-Url: https://codereview.chromium.org/2621163005
Cr-Commit-Position: refs/heads/master@{#448200}
Committed:
https://chromium.googlesource.com/chromium/src/+/918c5da31d9ccd80f22baca6151b...
==========

[commit-bot: I haz the power, 2017-02-06 01:21:54]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/918c5da31d9ccd80f22baca6151b...