Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2621793003: [Chromecast] Restore CastDevToolsManagerDelegateTest (Closed)

Created:
3 years, 11 months ago by derekjchow1
Modified:
3 years, 11 months ago
Reviewers:
yzshen1, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, pfeldman, halliwell+watch_chromium.org, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Restore CastDevToolsManagerDelegateTest R=alokp@chromium.org,yzshen@chromium.org BUG=crbug.com/665118 TEST=cast_shell_unittests Review-Url: https://codereview.chromium.org/2621793003 Cr-Commit-Position: refs/heads/master@{#442644} Committed: https://chromium.googlesource.com/chromium/src/+/3a461eebcb2c6fd9ae7fd066a1d9ad4f58fbfb59

Patch Set 1 #

Patch Set 2 : Add missing BUILD.gn dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chromecast/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/app/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/app/cast_test_launcher.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chromecast/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
derekjchow1
Adding mojo initialization to our test runner fixes up the devtools unittests. Alok, PTAL at ...
3 years, 11 months ago (2017-01-09 23:43:33 UTC) #1
alokp
rs lgtm (deferring to yzshen@ for verifying the usage of mojo edk)
3 years, 11 months ago (2017-01-10 00:03:43 UTC) #2
yzshen1
On 2017/01/10 00:03:43, alokp wrote: > rs lgtm (deferring to yzshen@ for verifying the usage ...
3 years, 11 months ago (2017-01-10 17:18:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621793003/1
3 years, 11 months ago (2017-01-10 17:30:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/288635)
3 years, 11 months ago (2017-01-10 17:37:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621793003/20001
3 years, 11 months ago (2017-01-10 17:46:36 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:04:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3a461eebcb2c6fd9ae7fd066a1d9...

Powered by Google App Engine
This is Rietveld 408576698