| OLD | NEW |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chromecast/browser/devtools/cast_devtools_manager_delegate.h" | 5 #include "chromecast/browser/devtools/cast_devtools_manager_delegate.h" |
| 6 | 6 |
| 7 #include <memory> | 7 #include <memory> |
| 8 #include <unordered_set> | 8 #include <unordered_set> |
| 9 | 9 |
| 10 #include "base/bind.h" | 10 #include "base/bind.h" |
| 11 #include "base/memory/ptr_util.h" | 11 #include "base/memory/ptr_util.h" |
| 12 #include "content/public/browser/devtools_agent_host.h" | 12 #include "content/public/browser/devtools_agent_host.h" |
| 13 #include "content/public/browser/web_contents.h" | 13 #include "content/public/browser/web_contents.h" |
| 14 #include "content/public/test/test_content_client_initializer.h" | 14 #include "content/public/test/test_content_client_initializer.h" |
| 15 #include "content/public/test/test_renderer_host.h" | 15 #include "content/public/test/test_renderer_host.h" |
| 16 #include "content/public/test/web_contents_tester.h" | 16 #include "content/public/test/web_contents_tester.h" |
| 17 #include "testing/gtest/include/gtest/gtest.h" | 17 #include "testing/gtest/include/gtest/gtest.h" |
| 18 #include "ui/gl/test/gl_surface_test_support.h" |
| 18 | 19 |
| 19 namespace chromecast { | 20 namespace chromecast { |
| 20 namespace shell { | 21 namespace shell { |
| 21 | 22 |
| 22 class CastDevToolsManagerDelegateTest | 23 class CastDevToolsManagerDelegateTest |
| 23 : public content::RenderViewHostTestHarness { | 24 : public content::RenderViewHostTestHarness { |
| 24 public: | 25 public: |
| 25 using WebContentsSet = std::unordered_set<content::WebContents*>; | 26 using WebContentsSet = std::unordered_set<content::WebContents*>; |
| 26 | 27 |
| 27 CastDevToolsManagerDelegateTest() {} | 28 CastDevToolsManagerDelegateTest() {} |
| 28 ~CastDevToolsManagerDelegateTest() override {} | 29 ~CastDevToolsManagerDelegateTest() override {} |
| 29 | 30 |
| 30 void SetUp() override { | 31 void SetUp() override { |
| 32 gl::GLSurfaceTestSupport::InitializeOneOff(); |
| 31 initializer_ = base::MakeUnique<content::TestContentClientInitializer>(); | 33 initializer_ = base::MakeUnique<content::TestContentClientInitializer>(); |
| 32 content::RenderViewHostTestHarness::SetUp(); | 34 content::RenderViewHostTestHarness::SetUp(); |
| 33 devtools_manager_delegate_ = | 35 devtools_manager_delegate_ = |
| 34 base::MakeUnique<CastDevToolsManagerDelegate>(); | 36 base::MakeUnique<CastDevToolsManagerDelegate>(); |
| 35 } | 37 } |
| 36 | 38 |
| 37 void TestDiscoveredTargets(const WebContentsSet& enabled_web_contents, | 39 void TestDiscoveredTargets(const WebContentsSet& enabled_web_contents, |
| 38 content::DevToolsAgentHost::List targets) { | 40 content::DevToolsAgentHost::List targets) { |
| 39 EXPECT_EQ(enabled_web_contents.size(), targets.size()); | 41 EXPECT_EQ(enabled_web_contents.size(), targets.size()); |
| 40 | 42 |
| 41 for (const auto& target : targets) { | 43 for (const auto& target : targets) { |
| 42 EXPECT_TRUE(enabled_web_contents.find(target->GetWebContents()) != | 44 EXPECT_TRUE(enabled_web_contents.find(target->GetWebContents()) != |
| 43 enabled_web_contents.end()) | 45 enabled_web_contents.end()) |
| 44 << "Discovered target not found in enabled WebContents."; | 46 << "Discovered target not found in enabled WebContents."; |
| 45 } | 47 } |
| 46 } | 48 } |
| 47 | 49 |
| 48 protected: | 50 protected: |
| 49 std::unique_ptr<content::TestContentClientInitializer> initializer_; | 51 std::unique_ptr<content::TestContentClientInitializer> initializer_; |
| 50 std::unique_ptr<CastDevToolsManagerDelegate> devtools_manager_delegate_; | 52 std::unique_ptr<CastDevToolsManagerDelegate> devtools_manager_delegate_; |
| 51 | 53 |
| 52 private: | 54 private: |
| 53 DISALLOW_COPY_AND_ASSIGN(CastDevToolsManagerDelegateTest); | 55 DISALLOW_COPY_AND_ASSIGN(CastDevToolsManagerDelegateTest); |
| 54 }; | 56 }; |
| 55 | 57 |
| 56 // TODO(derekjchow): Make the tests pass on cast testbots. | 58 TEST_F(CastDevToolsManagerDelegateTest, TestSingletonGetter) { |
| 57 // crbug.com/665118 | |
| 58 TEST_F(CastDevToolsManagerDelegateTest, DISABLED_TestSingletonGetter) { | |
| 59 EXPECT_EQ(devtools_manager_delegate_.get(), | 59 EXPECT_EQ(devtools_manager_delegate_.get(), |
| 60 CastDevToolsManagerDelegate::GetInstance()); | 60 CastDevToolsManagerDelegate::GetInstance()); |
| 61 } | 61 } |
| 62 | 62 |
| 63 TEST_F(CastDevToolsManagerDelegateTest, DISABLED_NoWebContents) { | 63 TEST_F(CastDevToolsManagerDelegateTest, NoWebContents) { |
| 64 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( | 64 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( |
| 65 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, | 65 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, |
| 66 base::Unretained(this), WebContentsSet()))); | 66 base::Unretained(this), WebContentsSet()))); |
| 67 } | 67 } |
| 68 | 68 |
| 69 TEST_F(CastDevToolsManagerDelegateTest, DISABLED_DisabledWebContents) { | 69 TEST_F(CastDevToolsManagerDelegateTest, DisabledWebContents) { |
| 70 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( | 70 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( |
| 71 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, | 71 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, |
| 72 base::Unretained(this), WebContentsSet()))); | 72 base::Unretained(this), WebContentsSet()))); |
| 73 } | 73 } |
| 74 | 74 |
| 75 TEST_F(CastDevToolsManagerDelegateTest, DISABLED_EnabledWebContents) { | 75 TEST_F(CastDevToolsManagerDelegateTest, EnabledWebContents) { |
| 76 devtools_manager_delegate_->EnableWebContentsForDebugging(web_contents()); | 76 devtools_manager_delegate_->EnableWebContentsForDebugging(web_contents()); |
| 77 WebContentsSet enabled_web_contents({web_contents()}); | 77 WebContentsSet enabled_web_contents({web_contents()}); |
| 78 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( | 78 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( |
| 79 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, | 79 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, |
| 80 base::Unretained(this), enabled_web_contents))); | 80 base::Unretained(this), enabled_web_contents))); |
| 81 } | 81 } |
| 82 | 82 |
| 83 } // namespace shell | 83 } // namespace shell |
| 84 } // namespace chromecast | 84 } // namespace chromecast |
| OLD | NEW |