Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2621783002: DevTools: Fix timeline tree grouping for v8 native urls for Domain/Subdomain (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 11 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix timeline tree grouping for v8 native urls for Domain/Subdomain BUG=679430 Review-Url: https://codereview.chromium.org/2621783002 Cr-Commit-Position: refs/heads/master@{#442420} Committed: https://chromium.googlesource.com/chromium/src/+/e2ce5fc799c1488d4c857505baae8b3a20f9cd76

Patch Set 1 #

Total comments: 1

Patch Set 2 : 4 landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
alph
3 years, 11 months ago (2017-01-09 20:29:43 UTC) #2
alph
3 years, 11 months ago (2017-01-09 20:29:44 UTC) #3
caseq
lgtm https://codereview.chromium.org/2621783002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/2621783002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode709 third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:709: Timeline.AggregatedTimelineTreeView._V8NativePrefix = 'native '; _v8NativePreifix
3 years, 11 months ago (2017-01-09 20:35:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621783002/20001
3 years, 11 months ago (2017-01-09 20:39:49 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 00:30:25 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e2ce5fc799c1488d4c857505baae...

Powered by Google App Engine
This is Rietveld 408576698