Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2621783002: DevTools: Fix timeline tree grouping for v8 native urls for Domain/Subdomain (Closed)
Patch Set: 4 landing Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index cc640277541731e21dc8d561afff092a425650c0..bf16e03a4c859afc899de243bd38a82d6cc3221d 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -506,6 +506,8 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
var name = node.id;
if (Timeline.AggregatedTimelineTreeView._isExtensionInternalURL(name))
name = Common.UIString('[Chrome extensions overhead]');
+ else if (Timeline.AggregatedTimelineTreeView._isV8NativeURL(name))
+ name = Common.UIString('[V8 Runtime]');
else if (name.startsWith('chrome-extension'))
name = this._executionContextNamesByOrigin.get(name) || name;
return {name: name || Common.UIString('unattributed'), color: color};
@@ -635,6 +637,8 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
var url = TimelineModel.TimelineProfileTree.eventURL(event) || '';
if (Timeline.AggregatedTimelineTreeView._isExtensionInternalURL(url))
return Timeline.AggregatedTimelineTreeView._extensionInternalPrefix;
+ if (Timeline.AggregatedTimelineTreeView._isV8NativeURL(url))
+ return Timeline.AggregatedTimelineTreeView._v8NativePrefix;
var parsedURL = url.asParsedURL();
if (!parsedURL)
return '';
@@ -691,9 +695,18 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
static _isExtensionInternalURL(url) {
return url.startsWith(Timeline.AggregatedTimelineTreeView._extensionInternalPrefix);
}
+
+ /**
+ * @param {string} url
+ * @return {boolean}
+ */
+ static _isV8NativeURL(url) {
+ return url.startsWith(Timeline.AggregatedTimelineTreeView._v8NativePrefix);
+ }
};
Timeline.AggregatedTimelineTreeView._extensionInternalPrefix = 'extensions::';
+Timeline.AggregatedTimelineTreeView._v8NativePrefix = 'native ';
/**
* @enum {string}
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698