Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 262173013: Revert 267897 "Revert 267858 "Working around IO thread chrashes ..." (Closed)

Created:
6 years, 7 months ago by phoglund_chromium
Modified:
6 years, 7 months ago
Reviewers:
Niklas Enbom
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 267897 "Revert 267858 "Working around IO thread chrashes ..." > Revert 267858 "Working around IO thread chrashes for WebRTC test..." > > Android browser tests still failing at http://chromegw/i/client.webrtc/waterfall > > > Working around IO thread chrashes for WebRTC tests on Android. > > > > Because the content_browsertests tearDown logic is broken with respect > > to threading on Android, we here work around the problem by sleeping in > > the tearDown to give the IO thread time to finish its work. This will > > lengthen the execution time of the tests but hopefully make the tests > > stable enough to last us until the Clank team finds time to rewrite the > > tearDown logic. > > > > BUG=362852 > > > > Review URL: https://codereview.chromium.org/251323002 > > TBR=phoglund@chromium.org > > Review URL: https://codereview.chromium.org/262773014 Appears the revert may have been incorrect; speculative re-land. TBR=niklase@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M trunk/src/build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/browser/media/webrtc_browsertest.cc View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
phoglund_chromium
6 years, 7 months ago (2014-05-06 09:42:09 UTC) #1
phoglund_chromium
Committed patchset #1 manually as r268474.
6 years, 7 months ago (2014-05-06 09:42:37 UTC) #2
Niklas Enbom
6 years, 7 months ago (2014-05-06 14:48:41 UTC) #3
Message was sent while issue was closed.
lgtm
On 2014/05/06 09:42:37, phoglund wrote:
> Committed patchset #1 manually as r268474.

Powered by Google App Engine
This is Rietveld 408576698