Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 251323002: Working around IO thread chrashes for WebRTC tests on Android. (Closed)

Created:
6 years, 7 months ago by phoglund_chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Working around IO thread chrashes for WebRTC tests on Android. Because the content_browsertests tearDown logic is broken with respect to threading on Android, we here work around the problem by sleeping in the tearDown to give the IO thread time to finish its work. This will lengthen the execution time of the tests but hopefully make the tests stable enough to last us until the Clank team finds time to rewrite the tearDown logic. BUG=362852 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267858

Patch Set 1 #

Patch Set 2 : Sleeping five seconds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 1 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
phoglund_chromium
6 years, 7 months ago (2014-04-29 14:01:59 UTC) #1
phoglund_chromium
Hmm, I'm a bit confused. The run succeeded locally (it had been failing earlier) but ...
6 years, 7 months ago (2014-04-29 14:41:21 UTC) #2
phoglund_chromium
This seems to help anecdotally. It's ugly but I don't have a better idea (and ...
6 years, 7 months ago (2014-04-30 13:06:43 UTC) #3
tommi (sloooow) - chröme
lgtm - rather ugly hack but I agree with you that it's better to have ...
6 years, 7 months ago (2014-05-01 10:30:41 UTC) #4
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-02 08:06:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/251323002/20001
6 years, 7 months ago (2014-05-02 08:07:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 08:22:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 08:22:02 UTC) #8
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-02 09:21:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/251323002/20001
6 years, 7 months ago (2014-05-02 09:22:16 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 17:53:52 UTC) #11
Message was sent while issue was closed.
Change committed as 267858

Powered by Google App Engine
This is Rietveld 408576698