Issue 262773014: Revert 267858 "Working around IO thread chrashes for WebRTC test..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262773014: Revert 267858 "Working around IO thread chrashes for WebRTC test..." (Closed)

Created:
6 years, 7 months ago by Niklas Enbom

Modified:
6 years, 7 months ago

Reviewers:
phoglund_chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 267858 "Working around IO thread chrashes for WebRTC test..." Android browser tests still failing at http://chromegw/i/client.webrtc/waterfall > Working around IO thread chrashes for WebRTC tests on Android. > > Because the content_browsertests tearDown logic is broken with respect > to threading on Android, we here work around the problem by sleeping in > the tearDown to give the IO thread time to finish its work. This will > lengthen the execution time of the tests but hopefully make the tests > stable enough to last us until the Clank team finds time to rewrite the > tearDown logic. > > BUG=362852 > > Review URL: https://codereview.chromium.org/251323002 TBR=phoglund@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267897

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -14 lines)			Patch
	M	trunk/src/build/android/pylib/gtest/filter/content_browsertests_disabled	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	trunk/src/content/browser/media/webrtc_browsertest.cc	View		3 chunks	+1 line, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r267897.

Expand Messages | Collapse Messages