Properly set extraColumns on group-report table for anomaly vs stoppage.

Properly set extraColumns on group-report table for anomaly vs stoppage.

BUG=catapult:#3132

Review-Url: https://codereview.chromium.org/2621643002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/118df6e4f47b194272fdaa596d2b716a86d7143c

[sullivan, 2017-01-09 15:19:53]

sullivan@chromium.org changed reviewers:
+ eakuefner@chromium.org

[sullivan, 2017-01-09 15:19:54]

Demo: https://dev-sullivan-fbd3bb6d-dot-chromeperf.appspot.com/alerts

Columns set correctly for anomaly:
https://dev-sullivan-fbd3bb6d-dot-chromeperf.appspot.com/group_report?sid=fe1...

Columns set correctly for data stoppage:
https://dev-sullivan-fbd3bb6d-dot-chromeperf.appspot.com/group_report?sid=843...

[sullivan, 2017-01-09 20:15:54]

The CQ bit was checked by sullivan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 20:16:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 20:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 20:32:22]

Dry run: Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[eakuefner, 2017-01-09 21:52:58]

lgtm

https://codereview.chromium.org/2621643002/diff/40001/dashboard/dashboard/ele...
File dashboard/dashboard/elements/group-report-page.html (right):

https://codereview.chromium.org/2621643002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/group-report-page.html:414: if (types.size == 1) {
nit: ===

[eakuefner, 2017-01-09 21:53:35]

Whoops. For completeness's sake, BUG= here as well if possible. Sorry for the
spurious mail.

[sullivan, 2017-01-09 22:09:08]

Description was changed from

==========
Properly set extraColumns on group-report table for anomaly vs stoppage.
==========

to

==========
Properly set extraColumns on group-report table for anomaly vs stoppage.

BUG=catapult:#3132
==========

[sullivan, 2017-01-09 22:10:41]

https://codereview.chromium.org/2621643002/diff/40001/dashboard/dashboard/ele...
File dashboard/dashboard/elements/group-report-page.html (right):

https://codereview.chromium.org/2621643002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/group-report-page.html:414: if (types.size == 1) {
On 2017/01/09 21:52:58, eakuefner wrote:
> nit: ===

Done.

[sullivan, 2017-01-09 22:10:46]

The CQ bit was checked by sullivan@chromium.org

[sullivan, 2017-01-09 22:10:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2621643002/#ps60001
(title: "addressed review comments")

[commit-bot: I haz the power, 2017-01-09 22:10:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 22:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:27:06]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[sullivan, 2017-01-09 22:27:43]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:27:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 22:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:36:12]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[sullivan, 2017-01-09 22:54:57]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:55:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 23:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:03:41]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[sullivan, 2017-01-09 23:26:08]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:26:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 23:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:33:12]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[sullivan, 2017-01-09 23:44:23]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:44:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:04:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484005463104160,
"parent_rev": "5ef80add8950497b1751515d60f44a317a711c9e", "commit_rev":
"118df6e4f47b194272fdaa596d2b716a86d7143c"}

[commit-bot: I haz the power, 2017-01-10 00:04:35]

Description was changed from

==========
Properly set extraColumns on group-report table for anomaly vs stoppage.

BUG=catapult:#3132
==========

to

==========
Properly set extraColumns on group-report table for anomaly vs stoppage.

BUG=catapult:#3132

Review-Url: https://codereview.chromium.org/2621643002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-01-10 00:04:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...