Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: dashboard/dashboard/alerts.py

Issue 2621643002: Properly set extraColumns on group-report table for anomaly vs stoppage. (Closed)
Patch Set: addressed review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/elements/group-report-page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/alerts.py
diff --git a/dashboard/dashboard/alerts.py b/dashboard/dashboard/alerts.py
index 5aaf109d550f2c05c91896186f34164d9d3a3ab1..ac05ea7fc690ebc342d277c7193fbd6de6c00f46 100644
--- a/dashboard/dashboard/alerts.py
+++ b/dashboard/dashboard/alerts.py
@@ -165,6 +165,7 @@ def GetAnomalyDict(anomaly_entity, bisect_status=None):
'improvement': anomaly_entity.is_improvement,
'bisect_status': bisect_status,
'recovered': anomaly_entity.recovered,
+ 'type': 'anomaly',
'units': anomaly_entity.units
})
return alert_dict
@@ -180,6 +181,7 @@ def _GetStoppageAlertDict(stoppage_alert_entity):
'mail_sent': stoppage_alert_entity.mail_sent,
'last_row_date': str(last_row_date.date()) if last_row_date else 'N/A',
'recovered': stoppage_alert_entity.recovered,
+ 'type': 'stoppage_alert',
})
return alert_dict
« no previous file with comments | « no previous file | dashboard/dashboard/elements/group-report-page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698