Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2621433002: dart2js-kernel: handle top-level / static unresolved methods / getters / setters (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-kernel: handle top-level / static unresolved methods / getters / setters R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/e9ea8e4d87b1959534c5d773d9f6cffd4df5c3d9

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : remove print #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -17 lines) Patch
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 1 chunk +20 lines, -11 lines 2 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/unresolved.dart View 5 chunks +22 lines, -5 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 2 chunks +67 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sra1
3 years, 11 months ago (2017-01-06 23:18:45 UTC) #2
sra1
3 years, 11 months ago (2017-01-09 19:19:26 UTC) #4
Emily Fortuna
lgtm
3 years, 11 months ago (2017-01-09 19:21:15 UTC) #5
sra1
Committed patchset #3 (id:40001) manually as e9ea8e4d87b1959534c5d773d9f6cffd4df5c3d9 (presubmit successful).
3 years, 11 months ago (2017-01-09 22:23:56 UTC) #7
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2621433002/diff/40001/pkg/compiler/lib/src/js_backend/backend_helpers.dart File pkg/compiler/lib/src/js_backend/backend_helpers.dart (right): https://codereview.chromium.org/2621433002/diff/40001/pkg/compiler/lib/src/js_backend/backend_helpers.dart#newcode660 pkg/compiler/lib/src/js_backend/backend_helpers.dart:660: _cachedCoreHelpers[name] ??= findCoreHelper(name); Im ok with either, but ...
3 years, 11 months ago (2017-01-11 19:08:03 UTC) #9
sra1
3 years, 11 months ago (2017-01-11 19:14:39 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/2621433002/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_helpers.dart (right):

https://codereview.chromium.org/2621433002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_helpers.dart:660:
_cachedCoreHelpers[name] ??= findCoreHelper(name);
On 2017/01/11 19:08:03, Siggi Cherem (dart-lang) wrote:
> Im ok with either, but any reason to prefer this or putIfAbsent?

putIfAbsent requires a closure argument (hence allocation) for each lookup.

Powered by Google App Engine
This is Rietveld 408576698