dart2js-kernel: handle top-level / static unresolved methods / getters / setters

pkg/compiler/lib/src/js_backend/backend_helpers.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.js_backend.helpers;
 
 import '../common.dart';
 import '../common/names.dart' show Identifiers, Uris;
 import '../common/resolution.dart' show Resolution;
 import '../compiler.dart' show Compiler;
@@ skipping 620 matching lines @@
   }
 
   Element get checkDeferredIsLoaded {
     return _findHelper('checkDeferredIsLoaded');
   }
 
   Element get throwNoSuchMethod {
     return _findHelper('throwNoSuchMethod');
   }
 
-  Element get genericNoSuchMethod =>
-      _genericNoSuchMethod ??= findCoreHelper('_genericNoSuchMethod');
-  MethodElement _genericNoSuchMethod;
+  Element get malformedTypeError => _cachedCoreHelper('_malformedTypeError');
+  Element get genericNoSuchMethod => _cachedCoreHelper('_genericNoSuchMethod');
+  Element get unresolvedConstructorError =>
+      _cachedCoreHelper('_unresolvedConstructorError');
+  Element get unresolvedStaticGetterError =>
+      _cachedCoreHelper('_unresolvedStaticGetterError');
+  Element get unresolvedStaticSetterError =>
+      _cachedCoreHelper('_unresolvedStaticSetterError');
+  Element get unresolvedStaticMethodError =>
+      _cachedCoreHelper('_unresolvedStaticMethodError');
+  Element get unresolvedTopLevelGetterError =>
+      _cachedCoreHelper('_unresolvedTopLevelGetterError');
+  Element get unresolvedTopLevelSetterError =>
+      _cachedCoreHelper('_unresolvedTopLevelSetterError');
+  Element get unresolvedTopLevelMethodError =>
+      _cachedCoreHelper('_unresolvedTopLevelMethodError');
 
-  Element get unresolvedConstructorError => _unresolvedConstructorError ??=
-      findCoreHelper('_unresolvedConstructorError');
-  MethodElement _unresolvedConstructorError;
-
-  Element get malformedTypeError =>
-      _malformedTypeError ??= findCoreHelper('_malformedTypeError');
-  MethodElement _malformedTypeError;
+  Map<String, Element> _cachedCoreHelpers = <String, Element>{};
+  Element _cachedCoreHelper(String name) =>
+      _cachedCoreHelpers[name] ??= findCoreHelper(name);

[Siggi Cherem (dart-lang), 2017/01/11 19:08:03]

Im ok with either, but any reason to prefer this or putIfAbsent?

[sra1, 2017/01/11 19:14:39]

putIfAbsent requires a closure argument (hence allocation) for each lookup.

 
   Element get createRuntimeType {
     return _findHelper('createRuntimeType');
   }
 
   Element get fallThroughError {
     return _findHelper("getFallThroughError");
   }
 
   Element get createInvocationMirror {
@@ skipping 204 matching lines @@
   }
 
   MethodElement get toStringForNativeObject {
     return _findHelper('toStringForNativeObject');
   }
 
   MethodElement get hashCodeForNativeObject {
     return _findHelper('hashCodeForNativeObject');
   }
 }