dart2js-kernel: handle top-level / static unresolved methods / getters / setters

pkg/compiler/lib/src/kernel/unresolved.dart

 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE.md file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import "../elements/resolution_types.dart"
     show ResolutionDartType, ResolutionInterfaceType;
 import "../elements/elements.dart"
     show
@@ skipping 12 matching lines @@
 import "kernel.dart" show Kernel;
 
 abstract class UnresolvedVisitor {
   Kernel get kernel;
 
   // Implemented in KernelVisitor
   AstElement get currentElement;
   bool get isVoidContext;
   ir.Arguments buildArguments(NodeList arguments);
   ir.TreeNode visitForValue(Expression node);
+  void associateCompoundComponents(Accessor accessor, Node node);
 
   // TODO(ahe): Delete this method.
   ir.InvalidExpression handleUnresolved(Node node);
 
   /// Similar to [Kernel.functionToIr] but returns null if [function] is a
   /// synthetic function created for error recovery.
   ir.Member possiblyErroneousFunctionToIr(FunctionElement function) {
     return kernel.isSyntheticError(function)
         ? null
         : kernel.functionToIr(function);
@@ skipping 74 matching lines @@
       [ir.Procedure exceptionBuilder]) {
     // TODO(asgerf): We should remove this fallback, but in some cases we do
     //   not get sufficient information to determine exactly what kind of
     //   setter it is.
     exceptionBuilder ??= kernel.getGenericNoSuchMethodBuilder();
     return buildThrowNoSuchMethodError(exceptionBuilder, new ir.NullLiteral(),
         name, new ir.Arguments(<ir.Expression>[argument]));
   }
 
   ir.Expression buildThrowUnresolvedSuperGetter(String name) {
+    // TODO(sra): This is incorrect when the superclass defines noSuchMethod.
     return buildThrowNoSuchMethodError(kernel.getUnresolvedSuperGetterBuilder(),
         new ir.ThisExpression(), name, new ir.Arguments.empty());
   }
 
   ir.Expression buildThrowUnresolvedSuperSetter(
       String name, ir.Expression argument) {
     return buildThrowNoSuchMethodError(
         kernel.getUnresolvedSuperSetterBuilder(),
         new ir.ThisExpression(),
         name,
@@ skipping 125 matching lines @@
       Node rhs,
       _) {
     return buildThrowUnresolvedSetter('${node.selector}', visitForValue(rhs),
         kernel.getUnresolvedStaticSetterBuilder());
   }
 
   ir.Expression visitUnresolvedStaticSetterPostfix(Send node,
       MethodElement getter, Element element, IncDecOperator operator, _) {
     var accessor = new ClassStaticAccessor(
         this, getter.name, possiblyErroneousFunctionToIr(getter), null);
-    return accessor.buildPostfixIncrement(new ir.Name(operator.selectorName),
+    var result = accessor.buildPostfixIncrement(
+        new ir.Name(operator.selectorName),
         voidContext: isVoidContext);
+    associateCompoundComponents(accessor, node);
+    return result;
   }
 
   ir.Expression visitUnresolvedStaticSetterPrefix(Send node,
       MethodElement getter, Element element, IncDecOperator operator, _) {
     var accessor = new ClassStaticAccessor(
         this, getter.name, possiblyErroneousFunctionToIr(getter), null);
-    return accessor.buildPrefixIncrement(new ir.Name(operator.selectorName),
+    var result = accessor.buildPrefixIncrement(
+        new ir.Name(operator.selectorName),
         voidContext: isVoidContext);
+    associateCompoundComponents(accessor, node);
+    return result;
   }
 
   ir.Expression visitUnresolvedStaticSetterSetIfNull(
       Send node, MethodElement getter, Element element, Node rhs, _) {
     var accessor = new ClassStaticAccessor(
         this, getter.name, possiblyErroneousFunctionToIr(getter), null);
     return accessor.buildNullAwareAssignment(visitForValue(rhs), null,
         voidContext: isVoidContext);
   }
 
   ir.Expression visitUnresolvedSuperBinary(
       Send node, Element element, BinaryOperator operator, Node argument, _) {
+    // TODO(sra): This is incorrect when the superclass defines noSuchMethod.
     return buildThrowNoSuchMethodError(
         kernel.getUnresolvedSuperMethodBuilder(),
         new ir.ThisExpression(),
         operator.selectorName,
         new ir.Arguments(<ir.Expression>[visitForValue(argument)]));
   }
 
   ir.Expression visitUnresolvedSuperCompound(
       Send node, Element element, AssignmentOperator operator, Node rhs, _) {
     return buildThrowUnresolvedSuperGetter('${node.selector}');
@@ skipping 210 matching lines @@
 
   ir.Expression visitUnresolvedTopLevelSetterCompound(
       Send node,
       MethodElement getter,
       Element element,
       AssignmentOperator operator,
       Node rhs,
       _) {
     var accessor = new TopLevelStaticAccessor(
         this, getter.name, possiblyErroneousFunctionToIr(getter), null);
-    return accessor.buildCompoundAssignment(
+    var result = accessor.buildCompoundAssignment(
         new ir.Name(operator.selectorName), visitForValue(rhs),
         voidContext: isVoidContext);
+    associateCompoundComponents(accessor, node);
+    return result;
   }
 
   ir.Expression visitUnresolvedTopLevelSetterPostfix(Send node,
       MethodElement getter, Element element, IncDecOperator operator, _) {
     var accessor = new TopLevelStaticAccessor(
         this, getter.name, possiblyErroneousFunctionToIr(getter), null);
-    return accessor.buildPostfixIncrement(new ir.Name(operator.selectorName),
+    var result = accessor.buildPostfixIncrement(
+        new ir.Name(operator.selectorName),
         voidContext: isVoidContext);
+    associateCompoundComponents(accessor, node);
+    return result;
   }
 
   ir.Expression visitUnresolvedTopLevelSetterPrefix(Send node,
       MethodElement getter, Element element, IncDecOperator operator, _) {
     var accessor = new TopLevelStaticAccessor(
         this, getter.name, possiblyErroneousFunctionToIr(getter), null);
-    return accessor.buildPrefixIncrement(new ir.Name(operator.selectorName),
+    var result = accessor.buildPrefixIncrement(
+        new ir.Name(operator.selectorName),
         voidContext: isVoidContext);
+    associateCompoundComponents(accessor, node);
+    return result;
   }
 
   ir.Expression visitUnresolvedTopLevelSetterSetIfNull(
       Send node, MethodElement getter, Element element, Node rhs, _) {
     var accessor = new TopLevelStaticAccessor(
         this, getter.name, possiblyErroneousFunctionToIr(getter), null);
     return accessor.buildNullAwareAssignment(visitForValue(rhs), null,
         voidContext: isVoidContext);
   }
 
@@ skipping 14 matching lines @@
     return buildUnresolvedSuperIndexAccessor(index, element)
         .buildNullAwareAssignment(visitForValue(rhs), null);
   }
 
   ir.Expression visitUnresolvedSuperSet(
       Send node, Element element, Node rhs, _) {
     return buildThrowUnresolvedSuperSetter(
         '${node.selector}', visitForValue(rhs));
   }
 }