Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 2621413003: [Contextual Search] Do not log contextual cards data shown if quick action was shown (Closed)

Created:
3 years, 11 months ago by Theresa
Modified:
3 years, 11 months ago
Reviewers:
Donn Denman
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Do not log contextual cards data shown if quick action was shown If a quick action was shown, contextual cards data for a thumbnail/caption were not shown, so the histograms for whether contextual cards data was shown should log "false". BUG=680229 Review-Url: https://codereview.chromium.org/2621413003 Cr-Commit-Position: refs/heads/master@{#443006} Committed: https://chromium.googlesource.com/chromium/src/+/521d81c3147eaa7d24b544a3075cb230a411c7aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Theresa
ptal
3 years, 11 months ago (2017-01-11 20:02:42 UTC) #4
Donn Denman
lgtm
3 years, 11 months ago (2017-01-11 21:03:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621413003/1
3 years, 11 months ago (2017-01-11 21:05:29 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:12:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/521d81c3147eaa7d24b544a3075c...

Powered by Google App Engine
This is Rietveld 408576698