Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2621413003: [Contextual Search] Do not log contextual cards data shown if quick action was shown (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
index e6c0ff1bdca11579b8ca528a2dea41ba5571e9d8..edbf1afa2ac2bd000ff246236949714b7afbb038 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
@@ -696,7 +696,9 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
doLiteralSearch = true;
}
- boolean receivedContextualCardsData = !TextUtils.isEmpty(caption)
+ boolean quickActionShown =
+ mSearchPanel.getSearchBarControl().getQuickActionControl().hasQuickAction();
+ boolean receivedContextualCardsData = !quickActionShown && !TextUtils.isEmpty(caption)
|| !TextUtils.isEmpty(thumbnailUrl);
if (ContextualSearchFieldTrial.shouldHideContextualCardsData()) {
// Clear the thumbnail URL and caption so that they are not displayed in the bar. This
@@ -723,8 +725,6 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
}
if (ContextualSearchFieldTrial.isContextualSearchSingleActionsEnabled()) {
- boolean quickActionShown =
- mSearchPanel.getSearchBarControl().getQuickActionControl().hasQuickAction();
ContextualSearchUma.logQuickActionShown(quickActionShown, quickActionCategory);
mSearchPanel.getPanelMetrics().setWasQuickActionShown(quickActionShown,
quickActionCategory);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698