Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2621343003: Return the enclosing composited PaintLayer rather than containingBlock for floats. (Closed)

Created:
3 years, 11 months ago by chrishtr
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2978
Project:
chromium
Visibility:
Public.

Description

Return the enclosing composited PaintLayer rather than containingBlock for floats. A previous patch failed to return the composited PaintLayer, which is what GraphicsLayerUpdater expected. BUG=679667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2624843002 Cr-Commit-Position: refs/heads/master@{#442778} (cherry picked from commit e00ffecc157dfa92f60c583cd3bfab7f102b65ae) Review-Url: https://codereview.chromium.org/2621343003 . Cr-Commit-Position: refs/branch-heads/2978@{#3} Cr-Branched-From: e2867aed46b3f00f3735d310144d6ef638f8be1a-refs/heads/master@{#442756} Committed: https://chromium.googlesource.com/chromium/src/+/e9d7b27fb83ad0bfcdc303d5228c5a51d68f526e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chrishtr
3 years, 11 months ago (2017-01-11 18:25:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e9d7b27fb83ad0bfcdc303d5228c5a51d68f526e.

Powered by Google App Engine
This is Rietveld 408576698