Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2621303002: [cleanup] Refactor builtins-object.cc to use TF_BUILTIN macro (Closed)

Created:
3 years, 11 months ago by jgruber
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Refactor builtins-object.cc to use TF_BUILTIN macro BUG= Review-Url: https://codereview.chromium.org/2621303002 Cr-Commit-Position: refs/heads/master@{#42226} Committed: https://chromium.googlesource.com/v8/v8/+/3e362c755b1023dce1c2c7e4aad2a4bb5c5a5b70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -295 lines) Patch
M src/builtins/builtins-object.cc View 4 chunks +220 lines, -295 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
jgruber
Took care of this one since I was touching it anyways. PTAL
3 years, 11 months ago (2017-01-11 12:14:24 UTC) #6
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-11 13:25:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621303002/1
3 years, 11 months ago (2017-01-11 13:28:38 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 13:30:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3e362c755b1023dce1c2c7e4aad2a4bb5c5...

Powered by Google App Engine
This is Rietveld 408576698