Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2619163004: [stubs] Add CreateIterResultObject stub (Closed)

Created:
3 years, 11 months ago by jgruber
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy, Igor Sheludko
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add CreateIterResultObject stub Most notably, the interpreter now calls this stub instead of the runtime. BUG= Review-Url: https://codereview.chromium.org/2619163004 Cr-Commit-Position: refs/heads/master@{#42218} Committed: https://chromium.googlesource.com/v8/v8/+/8713dc57775726e235d8449d7284ab411c3349d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -107 lines) Patch
M src/builtins/builtins.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins/builtins-generator.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 chunk +18 lines, -17 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 15 chunks +40 lines, -40 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 22 chunks +44 lines, -44 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
jgruber
We discussed inlining offline - the advantage of the current solution is that we can ...
3 years, 11 months ago (2017-01-11 09:00:23 UTC) #6
Benedikt Meurer
LGTM, let's go with this for now.
3 years, 11 months ago (2017-01-11 10:34:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619163004/1
3 years, 11 months ago (2017-01-11 11:31:27 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 11:34:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8713dc57775726e235d8449d7284ab411c3...

Powered by Google App Engine
This is Rietveld 408576698