Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 2621163005: Remove all use of FileHandlersInfo from desktop shortcut creation. (Closed)
Patch Set: Mac tests: Remove FileHandlersInfo references (plus tiny rebase). Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/create_application_shortcut_view.cc
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc
index d483bd1cfffe5b587a359afcf883da84d61a0e3f..cc927953dc78c9d19345f744814642ce51479146 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.cc
+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc
@@ -385,9 +385,9 @@ bool CreateApplicationShortcutView::Accept() {
creation_locations.in_quick_launch_bar = false;
#endif
- web_app::CreateShortcutsWithInfo(
- web_app::SHORTCUT_CREATION_BY_USER, creation_locations,
- std::move(shortcut_info_), file_handlers_info_);
+ web_app::CreateShortcutsWithInfo(web_app::SHORTCUT_CREATION_BY_USER,
+ creation_locations,
+ std::move(shortcut_info_));
return true;
}
@@ -521,11 +521,9 @@ CreateChromeApplicationShortcutView::CreateChromeApplicationShortcutView(
InitControls(DIALOG_LAYOUT_APP_SHORTCUT);
- // Get shortcut, icon and file handler information; they are needed for
- // creating the shortcut.
- web_app::GetInfoForApp(
- app,
- profile,
+ // Get shortcut and icon information; needed for creating the shortcut.
+ web_app::GetShortcutInfoForApp(
+ app, profile,
base::Bind(&CreateChromeApplicationShortcutView::OnAppInfoLoaded,
weak_ptr_factory_.GetWeakPtr()));
}
@@ -545,8 +543,6 @@ bool CreateChromeApplicationShortcutView::Cancel() {
}
void CreateChromeApplicationShortcutView::OnAppInfoLoaded(
- std::unique_ptr<web_app::ShortcutInfo> shortcut_info,
- const extensions::FileHandlersInfo& file_handlers_info) {
+ std::unique_ptr<web_app::ShortcutInfo> shortcut_info) {
shortcut_info_ = std::move(shortcut_info);
- file_handlers_info_ = file_handlers_info;
}

Powered by Google App Engine
This is Rietveld 408576698