Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2621143007: Make small sub-target of gin that can be used in browser without v8 dep (Closed)

Created:
3 years, 11 months ago by scottmg
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make small sub-target of gin that can be used in browser without v8 dep This severs some of the remaining ties between browser dll and gin-proper. R=jochen@chromium.org BUG=581766 Review-Url: https://codereview.chromium.org/2621143007 Cr-Commit-Position: refs/heads/master@{#445133} Committed: https://chromium.googlesource.com/chromium/src/+/8f970b126061dde068c576e2a6add0e3ba2d8275

Patch Set 1 #

Patch Set 2 : #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +4 lines, -1 line 0 comments Download
M gin/BUILD.gn View 4 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (20 generated)
scottmg
3 years, 11 months ago (2017-01-19 22:01:45 UTC) #18
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-20 07:33:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621143007/20001
3 years, 11 months ago (2017-01-20 19:23:56 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:38:36 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f970b126061dde068c576e2a6ad...

Powered by Google App Engine
This is Rietveld 408576698