Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: gin/BUILD.gn

Issue 2621143007: Make small sub-target of gin that can be used in browser without v8 dep (Closed)
Patch Set: #include Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/app/content_main_runner.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/BUILD.gn
diff --git a/gin/BUILD.gn b/gin/BUILD.gn
index 72d0125d92c7d525abaac9f9c7a2596c08155d95..362ab0e4bccb1cde17098b9c3380c67944f71c65 100644
--- a/gin/BUILD.gn
+++ b/gin/BUILD.gn
@@ -5,6 +5,24 @@
import("//testing/test.gni")
import("//v8/gni/v8.gni")
+# This is depended upon from the browser DLL on Windows, where V8 is not used,
+# but features are enabled. This cannot depend on V8.
+source_set("gin_features") {
+ sources = [
+ "gin_export.h",
+ "gin_features.cc",
+ "public/gin_features.h",
+ ]
+
+ defines = [ "GIN_IMPLEMENTATION" ]
+
+ deps = [
+ "//base",
+ ]
+
+ assert_no_deps = [ "//v8" ]
+}
+
component("gin") {
sources = [
"arguments.cc",
@@ -21,7 +39,6 @@ component("gin") {
"function_template.cc",
"function_template.h",
"gin_export.h",
- "gin_features.cc",
"handle.h",
"interceptor.cc",
"interceptor.h",
@@ -46,7 +63,6 @@ component("gin") {
"public/context_holder.h",
"public/debug.h",
"public/gin_embedders.h",
- "public/gin_features.h",
"public/isolate_holder.h",
"public/v8_idle_task_runner.h",
"public/v8_platform.h",
@@ -83,6 +99,7 @@ component("gin") {
"//v8",
]
deps = [
+ ":gin_features",
"//base/third_party/dynamic_annotations",
"//crypto",
]
« no previous file with comments | « content/app/content_main_runner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698