Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2621043002: Add UserCounter for Top Navigation in sandbox (Closed)

Created:
3 years, 11 months ago by gogerald1
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Add UserCounter for Top Navigation in sandbox To tell us the % of page views that do top navigations in sandboxed iframes w/ or w/o 'allow-top-navigation' and user gesture. This is for this intent to implement/ship feature: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Flt2IixYQK4 BUG=662506 Review-Url: https://codereview.chromium.org/2614073004 Cr-Commit-Position: refs/heads/master@{#442072} (cherry picked from commit 3180362167493d3261e31d0cb4a7fa1f5180683f) Review-Url: https://codereview.chromium.org/2621043002 . Cr-Commit-Position: refs/branch-heads/2924@{#715} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/5f34cba74251583df913a4fdd8fd0f4529c96adf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M third_party/WebKit/Source/core/frame/Frame.cpp View 2 chunks +24 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gogerald1
3 years, 11 months ago (2017-01-10 16:23:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f34cba74251583df913a4fdd8fd0f4529c96adf.

Powered by Google App Engine
This is Rietveld 408576698