Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2614073004: Add UserCounter for Top Navigation in sandbox (Closed)

Created:
3 years, 11 months ago by Bin Lu
Modified:
3 years, 11 months ago
Reviewers:
rkaplow, Rick Byers, ojan
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, asvitkine+watch_chromium.org, dcheng, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UserCounter for Top Navigation in sandbox To tell us the % of page views that do top navigations in sandboxed iframes w/ or w/o 'allow-top-navigation' and user gesture. This is for this intent to implement/ship feature: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Flt2IixYQK4 BUG=662506 Review-Url: https://codereview.chromium.org/2614073004 Cr-Commit-Position: refs/heads/master@{#442072} Committed: https://chromium.googlesource.com/chromium/src/+/3180362167493d3261e31d0cb4a7fa1f5180683f

Patch Set 1 #

Patch Set 2 : Remove unused code. #

Patch Set 3 : Fix a compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 2 2 chunks +24 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Bin Lu
3 years, 11 months ago (2017-01-06 17:05:28 UTC) #5
rkaplow
lgtm
3 years, 11 months ago (2017-01-06 19:09:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614073004/40001
3 years, 11 months ago (2017-01-06 21:13:22 UTC) #13
Rick Byers
LGTM
3 years, 11 months ago (2017-01-06 21:14:06 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 22:20:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3180362167493d3261e31d0cb4a7...

Powered by Google App Engine
This is Rietveld 408576698