Test that OmniboxViewViews has opaque background.

chrome/browser/ui/views/omnibox/omnibox_view_views.h

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
index 1b71318cda58998da2eb0e0aacaab87601d412fa..17f070a23ea2dd57df72044b8f41ee92c89986e0 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
@@ -26,6 +26,7 @@ class OmniboxPopupView;
 class Profile;
 
 namespace gfx {
+class RenderText;
 class SlideAnimation;
 }
 
@@ -33,7 +34,7 @@ namespace ui {
 class OSExchangeData;
 }  // namespace ui
 
-// Views-implementation of OmniboxView, based on the gtk implementation.
+// Views-implementation of OmniboxView.
 class OmniboxViewViews
     : public OmniboxView,
       public views::Textfield,
@@ -61,6 +62,9 @@ class OmniboxViewViews
   // Starts an animation that fades in the entire OmniboxView.
   void FadeIn();
 
+  // Returns the RenderText that is used by view::TextField.
+  gfx::RenderText* GetRenderTextForTesting();

[Peter Kasting, 2014/05/06 21:28:33]

Can we instead bracket this with #if defined(UNIT_TEST) and define it inline?:

// Expose the RenderText for tests.
#if defined(UNIT_TEST)
  gfx::RenderText* GetRenderText() {
    return views::Textfield::GetRenderText();
  }
#endif

This enforces that non-test code can't use it.

[Daniel Erat, 2014/05/07 18:43:02]

thanks, i didn't know about this #define. done.

+
   // View:
   virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) OVERRIDE;