Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6479)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Issue 262093014: Test that OmniboxViewViews has opaque background. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
index acb72528c2c73cc3562358dccdf152b05c6c961f..3b2e25bd2083a36532eb2260d80b1005f55ada9c 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
@@ -233,3 +233,13 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, SelectAllOnTabToFocus) {
EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
EXPECT_TRUE(omnibox_view->IsSelectAll());
}
+
+#if defined(OS_CHROMEOS)
Peter Kasting 2014/05/06 21:28:33 Why CrOS-only? Doesn't this affect other platform
Daniel Erat 2014/05/07 18:43:02 chrome os is the only platform where i've heard th
+IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, BackgroundIsOpaque) {
+ // The omnibox text should be rendered on an opaque background. Otherwise,
+ // Chrome OS is unable to use subpixel rendering: http://crbug.com/233364
+ OmniboxView* view = browser()->window()->GetLocationBar()->GetOmniboxView();
+ EXPECT_FALSE(static_cast<OmniboxViewViews*>(view)->
+ GetRenderTextForTesting()->background_is_transparent());
+}
+#endif

Powered by Google App Engine
This is Rietveld 408576698