Test that OmniboxViewViews has opaque background.

chrome/browser/ui/views/omnibox/omnibox_view_views.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/ui/omnibox/omnibox_view.h"
 #include "chrome/browser/ui/toolbar/toolbar_model.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/gfx/range/range.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/controls/textfield/textfield_controller.h"
 
 #if defined(OS_CHROMEOS)
 #include "chromeos/ime/input_method_manager.h"
 #endif
 
 class LocationBarView;
 class OmniboxPopupView;
 class Profile;
 
 namespace gfx {
+class RenderText;
 class SlideAnimation;
 }
 
 namespace ui {
 class OSExchangeData;
 }  // namespace ui
 
-// Views-implementation of OmniboxView, based on the gtk implementation.
+// Views-implementation of OmniboxView.
 class OmniboxViewViews
     : public OmniboxView,
       public views::Textfield,
       public gfx::AnimationDelegate,
 #if defined(OS_CHROMEOS)
       public
           chromeos::input_method::InputMethodManager::CandidateWindowObserver,
 #endif
       public views::TextfieldController {
  public:
   // The internal view class name.
   static const char kViewClassName[];
 
   OmniboxViewViews(OmniboxEditController* controller,
                    Profile* profile,
                    CommandUpdater* command_updater,
                    bool popup_window_mode,
                    LocationBarView* location_bar,
                    const gfx::FontList& font_list);
   virtual ~OmniboxViewViews();
 
   // Initialize, create the underlying views, etc;
   void Init();
 
   // Starts an animation that fades in the entire OmniboxView.
   void FadeIn();
 
+  // Returns the RenderText that is used by view::TextField.
+  gfx::RenderText* GetRenderTextForTesting();

[Peter Kasting, 2014/05/06 21:28:33]

Can we instead bracket this with #if defined(UNIT_TEST) and define it inline?:

// Expose the RenderText for tests.
#if defined(UNIT_TEST)
  gfx::RenderText* GetRenderText() {
    return views::Textfield::GetRenderText();
  }
#endif

This enforces that non-test code can't use it.

[Daniel Erat, 2014/05/07 18:43:02]

thanks, i didn't know about this #define. done.

+
   // View:
   virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) OVERRIDE;
 
   // OmniboxView:
   virtual void SaveStateToTab(content::WebContents* tab) OVERRIDE;
   virtual void OnTabChanged(const content::WebContents* web_contents) OVERRIDE;
   virtual void Update() OVERRIDE;
   virtual base::string16 GetText() const OVERRIDE;
   virtual void SetUserText(const base::string16& text,
                            const base::string16& display_text,
@@ skipping 151 matching lines @@
   // GESTURE_TAP. We want to select all only when the textfield is not in focus
   // and gets a tap. So we use this variable to remember focus state before tap.
   bool select_all_on_gesture_tap_;
 
   scoped_ptr<gfx::SlideAnimation> fade_in_animation_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_