Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared.

Source/core/svg/SVGAnimateElement.cpp

Index: Source/core/svg/SVGAnimateElement.cpp
diff --git a/Source/core/svg/SVGAnimateElement.cpp b/Source/core/svg/SVGAnimateElement.cpp
index 51ceaeb94f97ef63ce654ed71cd8a026d848c9e3..4cfd3ea0599c768d46a4d406a2e089ad5fbb6e92 100644
--- a/Source/core/svg/SVGAnimateElement.cpp
+++ b/Source/core/svg/SVGAnimateElement.cpp
@@ -49,8 +49,10 @@ PassRefPtr<SVGAnimateElement> SVGAnimateElement::create(Document& document)
 
 SVGAnimateElement::~SVGAnimateElement()
 {
+#if !ENABLE(OILPAN)
     if (targetElement())
         clearAnimatedType(targetElement());

[haraken, 2014/05/06 15:59:42]

clearAnimatedType is doing a bunch of non-trivial stuff and I'm not sure if we
can simply remove all of them from the destructor. kouhei-san would know better.

[kouhei (in TOK), 2014/05/07 01:43:13]

Removing <animate> tag means it should stop the SMIL animation immediately. See
m_animator->stopAnimValAnimation() being called from clearAnimatedType. Is the
behavior kept in this patch?

I'm not sure if the behavior is covered by the current layouttests.

[Mads Ager (chromium), 2014/05/07 12:13:16]

Kouhei, would it be possible to write a test case for this? Could you help me
either get a test case or create a patch with some instrumentation that will
show whether the animation is correctly stopped?

If you explicitly remove a SVGSMILElement you should get a 
SVGSMILElement::removedFrom call which I think should stop the animation. So
this code is only for the case where the SVGAnimateElement is still in the
hierarchy and is dying with the rest of the hierarchy.

+#endif
 }
 
 bool SVGAnimateElement::hasValidAttributeType()
@@ -203,7 +205,9 @@ void SVGAnimateElement::resetAnimatedType()
 
 static inline void applyCSSPropertyToTarget(SVGElement* targetElement, CSSPropertyID id, const String& value)
 {
+#if !ENABLE(OILPAN)
     ASSERT_WITH_SECURITY_IMPLICATION(!targetElement->m_deletionHasBegun);
+#endif
 
     MutableStylePropertySet* propertySet = targetElement->ensureAnimatedSMILStyleProperties();
     if (!propertySet->setProperty(id, value, false, 0))
@@ -214,7 +218,9 @@ static inline void applyCSSPropertyToTarget(SVGElement* targetElement, CSSProper
 
 static inline void removeCSSPropertyFromTarget(SVGElement* targetElement, CSSPropertyID id)
 {
+#if !ENABLE(OILPAN)
     ASSERT_WITH_SECURITY_IMPLICATION(!targetElement->m_deletionHasBegun);
+#endif
     targetElement->ensureAnimatedSMILStyleProperties()->removeProperty(id);
     targetElement->setNeedsStyleRecalc(LocalStyleChange);
 }
@@ -261,7 +267,9 @@ static inline void removeCSSPropertyFromTargetAndInstances(SVGElement* targetEle
 
 static inline void notifyTargetAboutAnimValChange(SVGElement* targetElement, const QualifiedName& attributeName)
 {
+#if !ENABLE(OILPAN)
     ASSERT_WITH_SECURITY_IMPLICATION(!targetElement->m_deletionHasBegun);
+#endif
     targetElement->invalidateSVGAttributes();
     targetElement->svgAttributeChanged(attributeName);
 }