Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: Source/core/svg/SVGElementInstance.h

Issue 262093006: Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Another build fix. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGElementInstance.h
diff --git a/Source/core/svg/SVGElementInstance.h b/Source/core/svg/SVGElementInstance.h
index b15d37273711dbb089c771c4c4883ba9f8739679..135632943f05354e9e1eed2fd77443cf5f24e5ec 100644
--- a/Source/core/svg/SVGElementInstance.h
+++ b/Source/core/svg/SVGElementInstance.h
@@ -37,8 +37,8 @@ class SVGElement;
class SVGUseElement;
// SVGElementInstance mimics Node, but without providing all its functionality
-class SVGElementInstance FINAL : public TreeShared<SVGElementInstance>, public EventTarget, public ScriptWrappable {
- DEFINE_EVENT_TARGET_REFCOUNTING(TreeShared<SVGElementInstance>);
+class SVGElementInstance FINAL : public TreeSharedWillBeRefCountedGarbageCollected<SVGElementInstance>, public EventTarget, public ScriptWrappable {
+ DEFINE_EVENT_TARGET_REFCOUNTING(TreeSharedWillBeRefCountedGarbageCollected<SVGElementInstance>);
public:
static PassRefPtr<SVGElementInstance> create(SVGUseElement* correspondingUseElement, SVGUseElement* directUseElement, PassRefPtr<SVGElement> originalElement);
@@ -73,7 +73,7 @@ public:
inline Document* ownerDocument() const;
- virtual void trace(Visitor*) { }
+ virtual void trace(Visitor*);
// EventTarget API
DECLARE_FORWARDING_ATTRIBUTE_EVENT_LISTENER(correspondingElement(), abort);
@@ -154,18 +154,18 @@ private:
virtual EventTargetData* eventTargetData() OVERRIDE;
virtual EventTargetData& ensureEventTargetData() OVERRIDE;
- SVGElementInstance* m_parentInstance;
+ RawPtrWillBeMember<SVGElementInstance> m_parentInstance;
SVGUseElement* m_correspondingUseElement;
SVGUseElement* m_directUseElement;
kouhei (in TOK) 2014/05/07 01:43:13 RawPtrWillBeMember?
Mads Ager (chromium) 2014/05/07 12:13:16 Yes, and I replace the RefPtr from SVGElementInsta
- RefPtr<SVGElement> m_element;
- RefPtr<SVGElement> m_shadowTreeElement;
+ RefPtrWillBeMember<SVGElement> m_element;
+ RefPtrWillBeMember<SVGElement> m_shadowTreeElement;
- SVGElementInstance* m_previousSibling;
- SVGElementInstance* m_nextSibling;
+ RawPtrWillBeMember<SVGElementInstance> m_previousSibling;
+ RawPtrWillBeMember<SVGElementInstance> m_nextSibling;
- SVGElementInstance* m_firstChild;
- SVGElementInstance* m_lastChild;
+ RawPtrWillBeMember<SVGElementInstance> m_firstChild;
+ RawPtrWillBeMember<SVGElementInstance> m_lastChild;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698