Oilpan: Make the Node hierarchy RefCountedGarbageCollected instead of TreeShared.

Source/core/svg/SVGAnimateElement.cpp

 /*
  * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 31 matching lines @@
     ScriptWrappable::init(this);
 }
 
 PassRefPtr<SVGAnimateElement> SVGAnimateElement::create(Document& document)
 {
     return adoptRef(new SVGAnimateElement(SVGNames::animateTag, document));
 }
 
 SVGAnimateElement::~SVGAnimateElement()
 {
+#if !ENABLE(OILPAN)
     if (targetElement())
         clearAnimatedType(targetElement());

[haraken, 2014/05/06 15:59:42]

clearAnimatedType is doing a bunch of non-trivial stuff and I'm not sure if we
can simply remove all of them from the destructor. kouhei-san would know better.

[kouhei (in TOK), 2014/05/07 01:43:13]

Removing <animate> tag means it should stop the SMIL animation immediately. See
m_animator->stopAnimValAnimation() being called from clearAnimatedType. Is the
behavior kept in this patch?

I'm not sure if the behavior is covered by the current layouttests.

[Mads Ager (chromium), 2014/05/07 12:13:16]

Kouhei, would it be possible to write a test case for this? Could you help me
either get a test case or create a patch with some instrumentation that will
show whether the animation is correctly stopped?

If you explicitly remove a SVGSMILElement you should get a 
SVGSMILElement::removedFrom call which I think should stop the animation. So
this code is only for the case where the SVGAnimateElement is still in the
hierarchy and is dying with the rest of the hierarchy.

+#endif
 }
 
 bool SVGAnimateElement::hasValidAttributeType()
 {
     SVGElement* targetElement = this->targetElement();
     if (!targetElement)
         return false;
 
     return m_animatedPropertyType != AnimatedUnknown && !hasInvalidCSSAttributeType();
 }
@@ skipping 132 matching lines @@
     if (shouldApply == ApplyCSSAnimation) {
         ASSERT(SVGAnimationElement::isTargetAttributeCSSProperty(targetElement, attributeName));
         computeCSSPropertyValue(targetElement, cssPropertyID(attributeName.localName()), baseValue);
     }
 
     m_animatedProperty = animator->constructFromString(baseValue);
 }
 
 static inline void applyCSSPropertyToTarget(SVGElement* targetElement, CSSPropertyID id, const String& value)
 {
+#if !ENABLE(OILPAN)
     ASSERT_WITH_SECURITY_IMPLICATION(!targetElement->m_deletionHasBegun);
+#endif
 
     MutableStylePropertySet* propertySet = targetElement->ensureAnimatedSMILStyleProperties();
     if (!propertySet->setProperty(id, value, false, 0))
         return;
 
     targetElement->setNeedsStyleRecalc(LocalStyleChange);
 }
 
 static inline void removeCSSPropertyFromTarget(SVGElement* targetElement, CSSPropertyID id)
 {
+#if !ENABLE(OILPAN)
     ASSERT_WITH_SECURITY_IMPLICATION(!targetElement->m_deletionHasBegun);
+#endif
     targetElement->ensureAnimatedSMILStyleProperties()->removeProperty(id);
     targetElement->setNeedsStyleRecalc(LocalStyleChange);
 }
 
 static inline void applyCSSPropertyToTargetAndInstances(SVGElement* targetElement, const QualifiedName& attributeName, const String& valueAsString)
 {
     ASSERT(targetElement);
     if (attributeName == anyQName() || !targetElement->inDocument() || !targetElement->parentNode())
         return;
 
@@ skipping 26 matching lines @@
     const HashSet<SVGElement*>& instances = targetElement->instancesForElement();
     const HashSet<SVGElement*>::const_iterator end = instances.end();
     for (HashSet<SVGElement*>::const_iterator it = instances.begin(); it != end; ++it) {
         if (SVGElement* shadowTreeElement = *it)
             removeCSSPropertyFromTarget(shadowTreeElement, id);
     }
 }
 
 static inline void notifyTargetAboutAnimValChange(SVGElement* targetElement, const QualifiedName& attributeName)
 {
+#if !ENABLE(OILPAN)
     ASSERT_WITH_SECURITY_IMPLICATION(!targetElement->m_deletionHasBegun);
+#endif
     targetElement->invalidateSVGAttributes();
     targetElement->svgAttributeChanged(attributeName);
 }
 
 static inline void notifyTargetAndInstancesAboutAnimValChange(SVGElement* targetElement, const QualifiedName& attributeName)
 {
     ASSERT(targetElement);
     if (attributeName == anyQName() || !targetElement->inDocument() || !targetElement->parentNode())
         return;
 
@@ skipping 117 matching lines @@
 
 SVGAnimatedTypeAnimator* SVGAnimateElement::ensureAnimator()
 {
     if (!m_animator)
         m_animator = SVGAnimatedTypeAnimator::create(m_animatedPropertyType, this, targetElement());
     ASSERT(m_animatedPropertyType == m_animator->type());
     return m_animator.get();
 }
 
 }