Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2620913002: Remove crash keys for 630495 and 630496 (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 11 months ago
Reviewers:
falken, jam
CC:
chromium-reviews, sadrul, tzik, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kinuko+watch, shaktisahu+watch-blimp_chromium.org, jsbell+serviceworker_chromium.org, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, lcwu+watch_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, kalyank, scf+watch-blimp_chromium.org, blink-worker-reviews_chromium.org, lethalantidote+watch-blimp_chromium.org, nhiroki, alokp+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, michaeln, shimazu+serviceworker_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, serviceworker-reviews, steimel+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove crash keys for 630495 and 630496 BUG=630495, 630496 Review-Url: https://codereview.chromium.org/2620913002 Cr-Commit-Position: refs/heads/master@{#442764} Committed: https://chromium.googlesource.com/chromium/src/+/10fd2deb815a0b4e286651cdc6737413a54a5ad9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -49 lines) Patch
M blimp/engine/app/blimp_engine_crash_keys.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chromecast/crash/cast_crash_keys.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
horo
falken@ Please review this.
3 years, 11 months ago (2017-01-10 07:35:05 UTC) #2
falken
lgtm
3 years, 11 months ago (2017-01-10 07:37:53 UTC) #3
horo
jam@ Could you please review this?
3 years, 11 months ago (2017-01-10 07:39:13 UTC) #5
jam
lgtm
3 years, 11 months ago (2017-01-10 15:45:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620913002/1
3 years, 11 months ago (2017-01-10 23:37:32 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 01:42:06 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10fd2deb815a0b4e286651cdc673...

Powered by Google App Engine
This is Rietveld 408576698