Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2620913002: Remove crash keys for 630495 and 630496 (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 187
188 // Temporary for http://crbug.com/621730 188 // Temporary for http://crbug.com/621730
189 {"postmessage_src_origin", kMediumSize}, 189 {"postmessage_src_origin", kMediumSize},
190 {"postmessage_dst_origin", kMediumSize}, 190 {"postmessage_dst_origin", kMediumSize},
191 {"postmessage_dst_url", kLargeSize}, 191 {"postmessage_dst_url", kLargeSize},
192 {"postmessage_script_info", kLargeSize}, 192 {"postmessage_script_info", kLargeSize},
193 193
194 // Temporary for https://crbug.com/616149. 194 // Temporary for https://crbug.com/616149.
195 {"existing_extension_pref_value_type", crash_keys::kSmallSize}, 195 {"existing_extension_pref_value_type", crash_keys::kSmallSize},
196 196
197 // Temporary for https://crbug.com/630495.
198 {"swdh_register_cannot_host_url", crash_keys::kLargeSize},
199 {"swdh_register_cannot_scope_url", crash_keys::kLargeSize},
200 {"swdh_register_cannot_script_url", crash_keys::kLargeSize},
201
202 // Temporary for https://crbug.com/630496.
203 {"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize},
204 {"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize},
205
206 // Temporary for https://crbug.com/668633. 197 // Temporary for https://crbug.com/668633.
207 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize}, 198 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize},
208 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize}, 199 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize},
209 }; 200 };
210 201
211 // This dynamic set of keys is used for sets of key value pairs when gathering 202 // This dynamic set of keys is used for sets of key value pairs when gathering
212 // a collection of data, like command line switches or extension IDs. 203 // a collection of data, like command line switches or extension IDs.
213 std::vector<base::debug::CrashKey> keys(fixed_keys, 204 std::vector<base::debug::CrashKey> keys(fixed_keys,
214 fixed_keys + arraysize(fixed_keys)); 205 fixed_keys + arraysize(fixed_keys));
215 206
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 bool ChromeCrashReporterClient::GetCollectStatsInSample() { 395 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
405 return install_static::GetCollectStatsInSample(); 396 return install_static::GetCollectStatsInSample();
406 } 397 }
407 398
408 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 399 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
409 const std::string& process_type) { 400 const std::string& process_type) {
410 // This is not used by Crashpad (at least on Windows). 401 // This is not used by Crashpad (at least on Windows).
411 NOTREACHED(); 402 NOTREACHED();
412 return true; 403 return true;
413 } 404 }
OLDNEW
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698