Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2620813002: For Geolocation.Header.TimeListening.* histograms change bucket for no location. (Closed)

Created:
3 years, 11 months ago by pdyson
Modified:
3 years, 11 months ago
Reviewers:
lbargu, Ted C, Ilya Sherman
CC:
agrieve+watch_chromium.org, asvitkine+watch_chromium.org, chromium-reviews, dominickn, jdonnelly+watch_chromium.org, kcarattini
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

For Geolocation.Header.TimeListening.* histograms change bucket for no location. Instead of using the last bucket, use the first bucket when no location is available. BUG=668923 Review-Url: https://codereview.chromium.org/2620813002 Cr-Commit-Position: refs/heads/master@{#442709} Committed: https://chromium.googlesource.com/chromium/src/+/0637efffc148042848a1b1977668e42c2a73e5b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
pdyson
3 years, 11 months ago (2017-01-10 01:14:50 UTC) #3
Ilya Sherman
Metrics LGTM. In general, we recommend renaming metrics when their semantics change, so that the ...
3 years, 11 months ago (2017-01-10 01:16:57 UTC) #5
pdyson
On 2017/01/10 at 01:16:57, isherman wrote: > Metrics LGTM. In general, we recommend renaming metrics ...
3 years, 11 months ago (2017-01-10 01:48:10 UTC) #6
lbargu
lgtm
3 years, 11 months ago (2017-01-10 08:54:42 UTC) #9
Ted C
lgtm
3 years, 11 months ago (2017-01-10 17:20:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620813002/1
3 years, 11 months ago (2017-01-10 22:18:06 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 22:23:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0637efffc148042848a1b1977668...

Powered by Google App Engine
This is Rietveld 408576698