chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java - Issue 2620813002: For Geolocation.Header.TimeListening.* histograms change bucket for no location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

Issue 2620813002: For Geolocation.Header.TimeListening.* histograms change bucket for no location. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

index f8d083dacfc9118e1d54e9b612affc49027de242..9323b0c3c412ba805f32d5adfebf5e923f1d5842 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

@@ -289,7 +289,7 @@ public class GeolocationHeader {

// Record the Location Age with a histogram.

recordLocationAgeHistogram(locationSource, locationAge);

long duration = sFirstLocationTime == Long.MAX_VALUE

- ? Long.MAX_VALUE

+ ? 0

: SystemClock.elapsedRealtime() - sFirstLocationTime;

// Record the Time Listening with a histogram.

recordTimeListeningHistogram(locationSource, locationAttached, duration);

« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »