Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2620783005: Make .prototype properties of Wasm constructors read-only (Closed)

Created:
3 years, 11 months ago by rossberg
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make .prototype properties of Wasm constructors read-only R=titzer@chromium.org BUG=v8:5817 Review-Url: https://codereview.chromium.org/2620783005 Cr-Commit-Position: refs/heads/master@{#42184} Committed: https://chromium.googlesource.com/v8/v8/+/8e9c90baa072fd4f771d37e22af524b6f4bb2b2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 5 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rossberg
3 years, 11 months ago (2017-01-10 15:08:20 UTC) #1
titzer
Schweet, lgtm
3 years, 11 months ago (2017-01-10 15:09:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620783005/1
3 years, 11 months ago (2017-01-10 15:12:02 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 15:41:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8e9c90baa072fd4f771d37e22af524b6f4b...

Powered by Google App Engine
This is Rietveld 408576698