Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: test/mjsunit/wasm/js-api.js

Issue 2620783005: Make .prototype properties of Wasm constructors read-only (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-js.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/wasm/js-api.js
diff --git a/test/mjsunit/wasm/js-api.js b/test/mjsunit/wasm/js-api.js
index abfbfd31397da941459c2246694b6b298a14de5d..60ed7474211db3d64f60d42f472f064616811bc0 100644
--- a/test/mjsunit/wasm/js-api.js
+++ b/test/mjsunit/wasm/js-api.js
@@ -22,8 +22,6 @@ function assertErrorMessage(func, type, msg) {
assertThrows(func, type);
}
-let PROP_FLAGS = false; // property flags are implemented correctly
-
let emptyModuleBinary = (() => {
var builder = new WasmModuleBuilder();
return new Int8Array(builder.toBuffer());
@@ -130,9 +128,9 @@ assertEq(new Module(emptyModuleBinary.buffer) instanceof Module, true);
// 'WebAssembly.Module.prototype' data property
let moduleProtoDesc = Object.getOwnPropertyDescriptor(Module, 'prototype');
assertEq(typeof moduleProtoDesc.value, "object");
-if (PROP_FLAGS) assertEq(moduleProtoDesc.writable, false);
-if (PROP_FLAGS) assertEq(moduleProtoDesc.enumerable, false);
-if (PROP_FLAGS) assertEq(moduleProtoDesc.configurable, false);
+assertEq(moduleProtoDesc.writable, false);
+assertEq(moduleProtoDesc.enumerable, false);
+assertEq(moduleProtoDesc.configurable, false);
// 'WebAssembly.Module.prototype' object
let moduleProto = Module.prototype;
@@ -234,9 +232,9 @@ assertErrorMessage(() => new Instance({}), TypeError, "first argument must be a
// 'WebAssembly.Instance.prototype' data property
let instanceProtoDesc = Object.getOwnPropertyDescriptor(Instance, 'prototype');
assertEq(typeof instanceProtoDesc.value, "object");
-if (PROP_FLAGS) assertEq(instanceProtoDesc.writable, false);
-if (PROP_FLAGS) assertEq(instanceProtoDesc.enumerable, false);
-if (PROP_FLAGS) assertEq(instanceProtoDesc.configurable, false);
+assertEq(instanceProtoDesc.writable, false);
+assertEq(instanceProtoDesc.enumerable, false);
+assertEq(instanceProtoDesc.configurable, false);
// 'WebAssembly.Instance.prototype' object
let instanceProto = Instance.prototype;
@@ -291,9 +289,9 @@ assertEq(new Memory({initial:1.5}).buffer.byteLength, kPageSize);
// 'WebAssembly.Memory.prototype' data property
let memoryProtoDesc = Object.getOwnPropertyDescriptor(Memory, 'prototype');
assertEq(typeof memoryProtoDesc.value, "object");
-if (PROP_FLAGS) assertEq(memoryProtoDesc.writable, false);
-if (PROP_FLAGS) assertEq(memoryProtoDesc.enumerable, false);
-if (PROP_FLAGS) assertEq(memoryProtoDesc.configurable, false);
+assertEq(memoryProtoDesc.writable, false);
+assertEq(memoryProtoDesc.enumerable, false);
+assertEq(memoryProtoDesc.configurable, false);
// 'WebAssembly.Memory.prototype' object
let memoryProto = Memory.prototype;
@@ -383,9 +381,9 @@ assertEq(new Table({initial:1, maximum:1.5, element:"anyfunc"}) instanceof Table
// 'WebAssembly.Table.prototype' data property
let tableProtoDesc = Object.getOwnPropertyDescriptor(Table, 'prototype');
assertEq(typeof tableProtoDesc.value, "object");
-if (PROP_FLAGS) assertEq(tableProtoDesc.writable, false);
-if (PROP_FLAGS) assertEq(tableProtoDesc.enumerable, false);
-if (PROP_FLAGS) assertEq(tableProtoDesc.configurable, false);
+assertEq(tableProtoDesc.writable, false);
+assertEq(tableProtoDesc.enumerable, false);
+assertEq(tableProtoDesc.configurable, false);
// 'WebAssembly.Table.prototype' object
let tableProto = Table.prototype;
« no previous file with comments | « src/wasm/wasm-js.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698